This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Remove hardcoded .so from MI_PlatformSpecific.cs - #34
Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit intoAug 5, 2019
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
requested a review
from Travis Plunk (TravisEz13)
January 23, 2019 01:07
Travis Plunk (TravisEz13)
approved these changes
Jan 23, 2019
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
Please validate before merging
Josh Dean (joshdean1)
suggested changes
Mar 17, 2019
Josh Dean (joshdean1)
left a comment
Josh Dean (joshdean1)
left a comment
There was a problem hiding this comment.
Since removing the .so, the below error now appears:
System.DllNotFoundException: Unable to load shared library 'libmi.so' or one of its dependencies.
Member
Author
|
Tested it on a private build. Basic tests worked fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33
Remove hardcoded .so from the MI_PlatformSpecific.cs to fix loading on MacOS.