feat(experiments): use PersonModal for funnel instead of SampledSessionsModal.#53363
Open
rodrigoi wants to merge 4 commits intoexperiments/experiment-actors-queryfrom
Open
feat(experiments): use PersonModal for funnel instead of SampledSessionsModal.#53363rodrigoi wants to merge 4 commits intoexperiments/experiment-actors-queryfrom
rodrigoi wants to merge 4 commits intoexperiments/experiment-actors-queryfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Size Change: +1.11 kB (0%) Total Size: 127 MB ℹ️ View Unchanged
|
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
rodrigoi
force-pushed
the
experiments/funnel-details-use-person-modal
branch
from
57325f2 to
286943e
Compare
rodrigoi
force-pushed
the
experiments/experiment-actors-query
branch
from
63cc64d to
e5107cd
Compare
rodrigoi
force-pushed
the
experiments/funnel-details-use-person-modal
branch
from
286943e to
d8a8270
Compare
Contributor
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…erson modal function.
rodrigoi
force-pushed
the
experiments/experiment-actors-query
branch
from
e402a96 to
d444bf2
Compare
rodrigoi
force-pushed
the
experiments/funnel-details-use-person-modal
branch
from
d806ab0 to
00c24f5
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| // - Step 0 with legacy: can use sampled sessions, show hint if sessionData exists | ||
| // - Step > 0 with new feature: can use actors query, show hint | ||
| // - Step > 0 with legacy: can use sampled sessions, show hint if sessionData exists | ||
| const hasClickableData = hasActorsQueryFeature ? stepIndex > 0 : !!sessionData |
Contributor
There was a problem hiding this comment.
The hasClickableData logic doesn't verify that experimentQuery exists when the feature flag is enabled. This will show the "Click to inspect actors" tooltip hint even when experimentQuery is undefined, causing the click handlers to do nothing (lines 133-134 check for experimentQuery existence).
// Should be:
const hasClickableData = hasActorsQueryFeature ? (stepIndex > 0 && !!experimentQuery) : !!sessionDataSimilarly, the cursor styles at lines 188-194 and 201-207 should also check for experimentQuery existence to avoid showing a pointer cursor when clicks won't work.
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user clicks a funnel metric or a details visualization, we show the corresponding
step_sessionsin the bespokeSampledSessionsModaldialog. This only shows information about persons who completed the step. This information is coming with the query results.Changes
We've updated the
StepBarcomponent to show different copy in the tooltip and to open aPersonsModalthat uses the newExperimentActorsQueryto show the correct group of persons based on the funnel step and the conversion condition. We are intentionally excluding the exposure event.This is hidden under a feature flag. Disabling the feature flag loads the original
SampledSessionsModal.How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update