feat: add card-course#63
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughTwo new modules introduce a Card-based UI component system. The Changes
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/card-groups.tsx`:
- Around line 23-33: The row currently uses whitespace-nowrap on the outer Card
which causes horizontal overflow when courseName is long; update the Card and
its CardContent children so the main title cell rendering courseName allows
truncation (e.g., remove/override whitespace-nowrap on that cell and add
truncation classes like overflow-hidden, text-ellipsis, and whitespace-normal or
truncate) while ensuring the metadata CardContent elements (the ones containing
CardAction + {location}/{language}) are non-shrinking (e.g., add flex-shrink-0)
so icons and metadata don’t collapse; locate the JSX using Card, the CardContent
that renders courseName, and the other CardContent metadata cells to apply these
class adjustments.
In `@src/components/ui/card.tsx`:
- Around line 69-75: The small SVG used only as a paint-server should be made
decorative: remove the <title>, move the <linearGradient id={gradientId} ...>
into a <defs> block, and mark the SVG helper with aria-hidden="true" and
focusable="false" so screen readers ignore it; update the element around
gradientId in card.tsx accordingly to reference the gradient from defs without
exposing the title.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a31716d8-d5d3-4b64-a8c6-6701991b96ef
📒 Files selected for processing (2)
src/components/card-groups.tsxsrc/components/ui/card.tsx
* Card initial commit * Text and icon gradients * Used figma classes * Moved card.tsx to components/ui/cards * refactor: move card.tsx into ui * Card initial commit * Text and icon gradients * Used figma classes * Moved card.tsx to components/ui/cards * refactor: move card.tsx into ui * chore: biome; fix: imports * aligned card.tsx between all cards * feat: optional gradient * fix: text transparency to see gradient * feat: added bg-background-blur to all cards * feat: add card-caption (#48) * created cardCaption.tsx * Updated card-caption to use react-icons * Adjusted font sizes * Updated card-caption to use react-icons * Adjusted font sizes * chore: biome * feat: typography * aligned card.tsx between all cards * fix: homepage cards layout * chore: biome * feat: add card-path-selection (#56) * created cardCaption.tsx * Updated card-caption to use react-icons * Adjusted font sizes * Added path selection cards * chore: biome * Updated card-caption to use react-icons * Adjusted font sizes * Added path selection cards * chore: biome * rm: card-caption from this branch * fix: typography * fix: imports and home layout * remove: bg-background-blur * feat: add card-course (#63) * feat: card-groups initial commit * fix: spacing between elements * chore: biome * fix: homepage layout for cards * remove: bg-background-blur * chore: biome * feat: add card-course-group (#67) * feat: card-course-group initial commit * chore: biome * fix: make text and icons black * feat: added cards to homepage; feat: added bg-background-blur to the card * remove: bg-background-blur * remove: truncate class * feat: secondary variant * chore: biome * chore: biome * fix: some of CodeRabbit's proposed fixes * required changes by @toto04 and CodeRabbit * feat: implemented @BIA3IA's card hover background * feat: added class to Card * feat: CardTitle is now * fix: removed text sizes from the base card components * fix: CardTitle props type --------- Co-authored-by: Tommaso Morganti <tommaso.morganti01@gmail.com> Co-authored-by: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>
* Card initial commit * Text and icon gradients * Used figma classes * Moved card.tsx to components/ui/cards * refactor: move card.tsx into ui * Card initial commit * Text and icon gradients * Used figma classes * Moved card.tsx to components/ui/cards * refactor: move card.tsx into ui * chore: biome; fix: imports * aligned card.tsx between all cards * feat: optional gradient * fix: text transparency to see gradient * feat: added bg-background-blur to all cards * feat: add card-caption (#48) * created cardCaption.tsx * Updated card-caption to use react-icons * Adjusted font sizes * Updated card-caption to use react-icons * Adjusted font sizes * chore: biome * feat: typography * aligned card.tsx between all cards * fix: homepage cards layout * chore: biome * feat: add card-path-selection (#56) * created cardCaption.tsx * Updated card-caption to use react-icons * Adjusted font sizes * Added path selection cards * chore: biome * Updated card-caption to use react-icons * Adjusted font sizes * Added path selection cards * chore: biome * rm: card-caption from this branch * fix: typography * fix: imports and home layout * remove: bg-background-blur * feat: add card-course (#63) * feat: card-groups initial commit * fix: spacing between elements * chore: biome * fix: homepage layout for cards * remove: bg-background-blur * chore: biome * feat: add card-course-group (#67) * feat: card-course-group initial commit * chore: biome * fix: make text and icons black * feat: added cards to homepage; feat: added bg-background-blur to the card * remove: bg-background-blur * remove: truncate class * feat: secondary variant * chore: biome * chore: biome * fix: some of CodeRabbit's proposed fixes * required changes by @toto04 and CodeRabbit * feat: implemented @BIA3IA's card hover background * feat: added class to Card * feat: CardTitle is now * feat: CTA first commit * fix: removed text sizes from the base card components * feat: CTA first commit * fix: CardTitle props type * feat: CTA first commit * feat: add new size to CardAction icon to accomodate the CTA icon size; fix: CTA size * remove: test CTAs in homepage * fix: wrap CTA in a Link tag; fix: mandatory icon * feat: hover effect --------- Co-authored-by: Tommaso Morganti <tommaso.morganti01@gmail.com> Co-authored-by: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>
Closes #54