Skip to content

Update ability changelog prose & trace in ability prose - #1699

Open
notblisy wants to merge 1 commit into
PokeAPI:masterfrom
notblisy:ability-changelog-prose-update
Open

notblisy wants to merge 1 commit into
PokeAPI:masterfrom
notblisy:ability-changelog-prose-update

Conversation

@notblisy

Copy link
Copy Markdown
Contributor

Change description

As discussed in #1423, ability changelog prose on live is inconsistent to how all other past values are presented.

Currently, any time an ability has a change, the change prose only shows what is different from the live, and not the entire ability. I have updated all the english text to be the entire account of what that ability does in each version group. This will allow this csv to be used the same as past_stats, for example.

In addition, while doing this, I noticed ability prose says trace cannot copy wonderguard, which is not true.

Most of my text is rewording of whatever ability_prose.csv has, but removing or adding relevant features of the abilities. Sometimes I replaced the entire thing with a smogon description, or my own, because the veekun phrasing can be quite verbose.

Lastly, I tried to remove any moves or abilities mentioned in an ability text that would reference things not in a given generation. IE, white smoke mentions heart swap in RS's entry, which did not exist then.

AI coding assistance disclosure

No AI was used while making this PR.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@notblisy

Copy link
Copy Markdown
Contributor Author

Not really sure what this static check fail is. Can someone inform me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant