Repository navigation
Conversation
Contributor
Author
|
Not really sure what this static check fail is. Can someone inform me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
As discussed in #1423, ability changelog prose on live is inconsistent to how all other past values are presented.
Currently, any time an ability has a change, the change prose only shows what is different from the live, and not the entire ability. I have updated all the english text to be the entire account of what that ability does in each version group. This will allow this csv to be used the same as past_stats, for example.
In addition, while doing this, I noticed ability prose says trace cannot copy wonderguard, which is not true.
Most of my text is rewording of whatever ability_prose.csv has, but removing or adding relevant features of the abilities. Sometimes I replaced the entire thing with a smogon description, or my own, because the veekun phrasing can be quite verbose.
Lastly, I tried to remove any moves or abilities mentioned in an ability text that would reference things not in a given generation. IE, white smoke mentions heart swap in RS's entry, which did not exist then.
AI coding assistance disclosure
No AI was used while making this PR.
Contributor check list