Skip to content

ofParameter name change improvements - #1

Merged
eduardfrigola merged 5 commits into
PlaymodesStudio:bugfix-ofParameter_change_namefrom
roymacdonald:bugfix-ofParameter_change_name
Sep 7, 2020
Merged

ofParameter name change improvements#1
eduardfrigola merged 5 commits into
PlaymodesStudio:bugfix-ofParameter_change_namefrom
roymacdonald:bugfix-ofParameter_change_name

Conversation

@roymacdonald

Copy link
Copy Markdown

Hey @eduardfrigola
Look at the changes I've done. As we discussed openframeworks#6576
I also added an ofEvent that gets notified when the name changes so any gui can update automagically.

I am testing and works fine

I think that if we get this merged into master then we should go for the ofxGui improvement so it listens to the name change.

@eduardfrigola

eduardfrigola commented Sep 4, 2020

Copy link
Copy Markdown
Member

Hi @roymacdonald
Thanks for the changes.
I have tested them with my use case and works as expected!

Having static function in ofParameterGroup makes everything very clear, that is nice!

Should it be another event, sent by ofParameterGroup, that tells if any parameter has changed name, similar to parameterChangedE()? If not you should need a listener for each parameter you have in the gui (thinking about adding this to ofxGui)

@roymacdonald

Copy link
Copy Markdown
Author

Hi,
right, there should be something like parameterChangedE() but for the name change. Although I already implemented ofxGui with listeners for the name changes. I think that there would be just as much extra lines of codes if I would use an event triggered by ofParameterGroup instead of each ofParameter.
I'll add anyways the event for the ofParameterGroup

@roymacdonald

Copy link
Copy Markdown
Author

@eduardfrigola I added an event in ofParameterGroup that is triggered when any of its children change name. Also implemented in ofxGui.

@eduardfrigola

Copy link
Copy Markdown
Member

Nice!
Thanks Roy!

Should I merge this and pr this branch to main repo?

@roymacdonald

roymacdonald commented Sep 7, 2020

Copy link
Copy Markdown
Author

Should I merge this and pr this branch to main repo?

Yes.

@eduardfrigola
eduardfrigola merged commit e96cb82 into PlaymodesStudio:bugfix-ofParameter_change_name Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants