Remove _constrain_dt_to_within_time_interval function#2754
Open
erikvansebille wants to merge 2 commits into
Open
Remove _constrain_dt_to_within_time_interval function#2754erikvansebille wants to merge 2 commits into
_constrain_dt_to_within_time_interval function#2754erikvansebille wants to merge 2 commits into
Conversation
As not needed anymore with recent kernel loop change This simplifies the Kernels and reverts Parcels-code#2378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While cleaning up some of the advection kernels, I realised that we don't need the
_constrain_dt_to_within_time_interval()helper function (implemented in #2378) anymore, as a recent change to the kernel loop has meant that RK-functions don't call outside the time_intervalThis simplifies the Kernels and makes them significantly more intuitive , as users don't need to figure out what this
_constrain_dt_to_within_time_interval()helper function does. It will also (slightly) speed up kernels, as there are less operations on the particlesChecklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None