Repository navigation
Allow players with passengers to be teleported via API - #14383
Open
Warriorrrr wants to merge 1 commit into
Open
Warriorrrr wants to merge 1 commit into
Warriorrrr wants to merge 1 commit into
Conversation
Doc94
approved these changes
Oct 16, 2026
Contributor
Shouldn't this be said a bit more explicitly on both teleports as well as addPassenger that behaviour on players differs from other entities, and on players specifically plugins would need to implement that? |
Contributor
|
100% on the end of masmc here, tho the hopes were that we'd be able to implement cross dimensional teleportation including passengers for players. The teleport transition already has a field to check if the teleport is API introduced so we can guard any non vanilla behaviour there for API calls only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested these changes and have not found any weird behavior mentioned in the comment, a cross dimension teleport with passengers correctly dismounts them just like /tp or going through a portal would.
This makes things easier for plugins that add passengers to players, as they'll no longer prevent other plugins from teleporting such players, but they're still responsible for removing or re-adding the passengers to the player after a dimension change. This is pretty easily achievable through the EntityDismountEvent & PlayerChangedWorldEvent.
Supersedes #14184
Closes #12093