Followup pr226#229
Merged
sizzlemctwizzle merged 2 commits intoOpenUserJS:masterfrom Jun 29, 2014
Merged
Conversation
added 2 commits
June 29, 2014 16:20
Applies to pr#226
Applies to OpenUserJS#226
Martii
referenced
this pull request
Jun 29, 2014
Add basic support for key prefixing Merging for sizzle... he can test and deploy but we're lagging behind a bit here.
Member
Author
|
Tested on dev with this script... with this pr checkout... tests okay with alternate Martii account... so it was just a display foobar... tracking if I'm the one to blame :( |
Martii
referenced
this pull request
in Martii/OpenUserJS.org
Jun 29, 2014
… probably stay in there since it's an `||` Applies to OpenUserJS#226 via OpenUserJS#208
Member
Author
|
Hmmm no idea how it was lost... I can't find a trace of it being reverted on GH. See also initial conversation: |
Member
|
Confirmed it works in dev and prod... merging... Deployed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try this @sizzlemctwizzle... I'm quite flustered that this happened after many, many, many hours of SOLID coding/testing and this showed up as a failed merge and needs verification... GRR... this is why we can't fall too far behind on prs.
Applies to #226