Added django allauth registration model by vaibhavsingh97 · Pull Request #147 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io

vaibhavsingh97 · 2017-10-17T15:16:14Z

Checklist

My branch is up-to-date with the upstream develop branch.
I have added necessary documentation (if appropriate).

Which issue does this PR fix?: fixes #95
Testing link: https://sheltered-depths-79669.herokuapp.com/

Todo:

Screenshots:
Login Form:

Signup Form:

Email Verification

Password Reset:

Change Password:

Features of Password Strength:

If the password is same as username and email address, it will show weak
It checks for too many character repetitions and the number of character classes used
uses zxcvbn

houndci-bot · 2017-10-17T15:16:23Z

+from django.http import HttpResponse
+
+def profile(request):
+    return render(request, "profile.html")


no newline at end of file

houndci-bot · 2017-10-17T15:16:23Z

+from django.shortcuts import render
+from django.http import HttpResponse
+
+def profile(request):


expected 2 blank lines, found 1

houndci-bot · 2017-10-17T15:16:23Z

@@ -0,0 +1,5 @@
+from django.shortcuts import render
+from django.http import HttpResponse


'django.http.HttpResponse' imported but unused

houndci-bot · 2017-10-17T15:16:23Z

+EMAIL_HOST_PASSWORD='Gorakhpur#1997'
+EMAIL_PORT=587
+EMAIL_USE_TLS=True
+LOGIN_REDIRECT_URL = "profile/"


no newline at end of file

houndci-bot · 2017-10-17T15:16:23Z

+EMAIL_HOST_USER='vaibhav.singh.14cse@bml.edu.in'
+EMAIL_HOST_PASSWORD='Gorakhpur#1997'
+EMAIL_PORT=587
+EMAIL_USE_TLS=True


missing whitespace around operator

houndci-bot · 2017-10-17T15:16:24Z

    os.path.join(BASE_DIR, 'main/'),
 )
+
+EMAIL_HOST='smtp.gmail.com'


missing whitespace around operator

houndci-bot · 2017-10-17T15:16:24Z

+        'NAME': 'django.contrib.auth.password_validation.CommonPasswordValidator',
+    },
+    {
+        'NAME': 'django.contrib.auth.password_validation.NumericPasswordValidator',


line too long (83 > 79 characters)

houndci-bot · 2017-10-17T15:16:24Z

+        'NAME': 'django.contrib.auth.password_validation.MinimumLengthValidator',
+    },
+    {
+        'NAME': 'django.contrib.auth.password_validation.CommonPasswordValidator',


line too long (82 > 79 characters)

houndci-bot · 2017-10-17T15:16:24Z

+        'NAME': 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',
+    },
+    {
+        'NAME': 'django.contrib.auth.password_validation.MinimumLengthValidator',


line too long (81 > 79 characters)

houndci-bot · 2017-10-17T15:16:24Z

+
+AUTH_PASSWORD_VALIDATORS = [
+    {
+        'NAME': 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',


line too long (91 > 79 characters)

houndci-bot · 2017-10-17T16:03:08Z

+        except user_cls.DoesNotExist:
+            return None
+        return None
+


blank line contains whitespace

houndci-bot · 2017-10-17T16:03:08Z

+
+class EmailLoginBackend(object):
+    '''
+    This class checks that the user can be authenticated via our backend and if it fails than normal authentication backend is used.


line too long (132 > 79 characters)

houndci-bot · 2017-10-17T19:47:14Z

+
+try {
+    if (!jQuery && module && module.exports) {
+        var jQuery = require("jquery"),


'jQuery' is already defined.

houndci-bot · 2017-10-18T11:41:18Z

+    data = {
+        'is_present': User.objects.filter(username__iexact=username).exists()
+    }
+    return JsonResponse(data)


no newline at end of file

houndci-bot · 2017-10-18T11:41:18Z

+urlpatterns = [
+    url(r'^accounts/', include('allauth.urls')),
+    url(r'^accounts/login/profile/', views.profile, name="profile"),
+    url(r'^ajax/validate_username/$', views.validate_username, name='validate_username'),


line too long (89 > 79 characters)

coveralls · 2017-10-18T12:37:30Z

Coverage remained the same at 69.474% when pulling 0614159 on vaibhavsingh97:Patch1/registrationModel into 2a0e5fd on OpenSourceHelpCommunity:predev.

coveralls · 2017-10-18T12:38:33Z

Coverage remained the same at 69.474% when pulling 0614159 on vaibhavsingh97:Patch1/registrationModel into 2a0e5fd on OpenSourceHelpCommunity:predev.

tapaswenipathak

I will make it live on another Heroku app first before we merge this to predev. This is on me.

First we all test this there and then come to code review or how we can make it better, if we can.

This is big to review and enables more than one feature in a single pull request, but all up for this, for obvious reasons! 🚀 ❤️

tapaswenipathak

This isn't making any previous features down, tested with separate Heroku deployment. We can test on predev itself and enhance things(if needed) and then merge to dev would be cleaner and all up. Merged. 🙌

houndci-bot reviewed Oct 17, 2017

View reviewed changes

vaibhavsingh97 force-pushed the Patch1/registrationModel branch from afd5db3 to 8914a0a Compare October 17, 2017 19:47

houndci-bot reviewed Oct 18, 2017

View reviewed changes

vaibhavsingh97 force-pushed the Patch1/registrationModel branch from bf4d12e to 32d8782 Compare October 18, 2017 11:42

vaibhavsingh97 requested review from jarifibrahim, nikhita and tapaswenipathak October 18, 2017 11:44

vaibhavsingh97 changed the title ~~[WIP] Added django allauth registration model~~ Added django allauth registration model Oct 18, 2017

Added django allauth registration model

0614159

vaibhavsingh97 force-pushed the Patch1/registrationModel branch from 8e16ed2 to 0614159 Compare October 18, 2017 12:37

tapaswenipathak reviewed Oct 18, 2017

View reviewed changes

vaibhavsingh97 added the status: Needs Review label Oct 19, 2017

tapaswenipathak merged commit 0614159 into OpenSourceHelpCommunity:predev Oct 22, 2017

tapaswenipathak reviewed Oct 22, 2017

View reviewed changes

		@@ -0,0 +1,5 @@
		from django.shortcuts import render
		from django.http import HttpResponse

Conversation

vaibhavsingh97 commented Oct 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 18, 2017

Uh oh!

coveralls commented Oct 18, 2017

Uh oh!

tapaswenipathak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tapaswenipathak left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vaibhavsingh97 commented Oct 17, 2017 •

edited

Loading

tapaswenipathak left a comment •

edited

Loading