Repository navigation
Conversation
Fixes OpenSCAP#2012 Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
ListUnits can include known but not-found dependencies. Skip these rather than collecting dummy properties. Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
hakarrr
requested review from
Mab879,
jan-cerny and
matusmarhefka
as code owners
November 10, 2026 18:13
|
Author
|
Could a maintainer review this fix to preserve real systemd unit instances during probe enumeration? Please let me know if changes or additional cases are needed before it can move forward. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #2012.
Keep
ListUnitFilesso disabled, unloaded units remain visible, then merge inListUnitsfor template instances and transient units. Deduplicate names before calling either probe's collector.Template names such as
user-runtime-dir@.serviceare skipped instead of losing their@. Instance names, including installedpersist@42.serviceentries, stay intact. Loaded entries withLoadState=not-foundare excluded.Tests:
python-dbusmockfixture that runs the compiledoscapagainst both systemd probes. It needs neither root nor host systemd.git diff --checkpassed. Published tree27c85d3ff7a33944c7354044676284dda1e039eematches the tested tree.Local build used released dependency headers/tools supplied outside the source tree, with documentation, Python/Perl bindings, and oscap-docker disabled. No tracked build settings changed. The full project suite, live host-systemd tests, and non-Linux builds were not run.