Repository navigation
Conversation
Use terse ID:title rows for standalone tailoring files and omit the benchmark hint from terse datastream tailoring output. Leave normal verbose info unchanged and handle profiles without local titles safely. Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
Cover titled, multiline, untitled and abstract profiles, missing benchmark references, empty tailoring files and datastream tailoring listings. Retain normal info headers and existing rule/variable listing behavior. Co-authored-by: generaltony007 <144252170+GeneralTony007@users.noreply.github.com>
hakarrr
requested review from
Mab879,
jan-cerny and
matusmarhefka
as code owners
November 10, 2026 17:50
|
Author
|
Could a maintainer review this info --profiles handling for XCCDF tailoring files? Please let me know if the behavior needs changing or if additional cases are needed before it can move forward. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2043.
Honor
oscap info --profiles tailoring.xmlby using the existing terseID:titleprinter instead of the normal document header, import time and verbose profile list. Terse listings of tailoring embedded in a source datastream also omit the benchmark hint, so their output contains only profile rows.Profiles without a locally defined title print an empty title field rather than passing NULL to
%s. This does not load a referenced benchmark or infer an inherited title. Normaloscap infooutput,--list-rulesand--list-varsbehavior are preserved.Extend the existing info CLI test with checks for:
Validation on Linux with GCC 11.4 and a native CMake build:
ctest --test-dir build -R 'API/XCCDF/(unittests|fix)|oscap_info_profiles' -j4 --output-on-failure: 97 passed, 3 skipped, 0 failed.git diff --checkpass.Dependencies were supplied locally without tracked dependency or build-configuration changes. Documentation, Python/Perl bindings and oscap-docker were disabled. The three skips cover XCCDF transformation, offline remediation and platform-specific system information. The full project test suite and non-Linux builds were not run.