Update target JDK to 11 and move to JakartaEE 9#132
Update target JDK to 11 and move to JakartaEE 9#132vharseko merged 33 commits intoOpenIdentityPlatform:masterfrom
Conversation
|
Maybe update the project version to 3.0.0-SNAPSHOT in this PR? |
maximthomas
force-pushed
the
update-jdk-11
branch
from
859f14e to
16b544e
Compare
| <version>2.0.1</version> | ||
| <groupId>jakarta.jms</groupId> | ||
| <artifactId>jakarta.jms-api</artifactId> | ||
| <version>3.1.0</version> |
There was a problem hiding this comment.
Jakarta JMS 3.1.0 is Jakarta EE 10, not 9 FYI. Depends on which version you want to upgrade to.
There was a problem hiding this comment.
Thank you for pointing that out.
Tomcat 10.1 supports Servlet version 6.0, which is part of Jakarta EE 10 https://tomcat.apache.org/whichversion.html
And Tomcat 10.0 is EOL
| </dependency> | ||
| <dependency> | ||
| <groupId>com.jayway.restassured</groupId> | ||
| <groupId>io.rest-assured</groupId> |
There was a problem hiding this comment.
Is the rest-assured upgrade related to these changes? Just wondering if it's needed for the Jakarta upgrade?
There was a problem hiding this comment.
Reverted rest-assured version for now, this is unnecessary change 5f86893
| "HttpOnly"); | ||
| assertThat(cookieCaptor.getValue()).contains("COOKIE_NAME=COOKIE_VALUE;", "Domain=www.example.com;", | ||
| "Expires="+df.format( | ||
| new Date(System.currentTimeMillis() + 6000 * 1000L))); |
There was a problem hiding this comment.
Not sure how reliable this test is going to be. If there's a clock change while running the test you might get a randomly failing test on your hands. If you really need to assert on this, use a fixed Clock instance instead?
Also could simplify 6000 * 1000L to 6_000_000L.
There was a problem hiding this comment.
Reverted the test, using Max-Age cookie attribute is more appropriate, see ad27745
| <animal-sniffer.signature.artifactId>java17</animal-sniffer.signature.artifactId> | ||
| <animal-sniffer.signature.version>1.0</animal-sniffer.signature.version> | ||
| <version.animal-sniffer.plugin>1.16</version.animal-sniffer.plugin> | ||
| <version.animal-sniffer.plugin>1.20</version.animal-sniffer.plugin> |
There was a problem hiding this comment.
Note that newer versions of animal-sniffer were sniffing out some binary incompatibilities. The persistit backend might not work on the latest versions of JDKs FYI.
| <version>3.1.0</version> | ||
| <groupId>jakarta.servlet</groupId> | ||
| <artifactId>jakarta.servlet-api</artifactId> | ||
| <version>6.0.0</version> |
There was a problem hiding this comment.
5.0.0 is Jakarta EE 9, 6.0.0 is Jakarta EE 10. Jetty 11 only supports Servlet API 5.0 (and Jetty 11 is EOL). Tomcat 10.0.x was servlet-api 5, Tomcat 10.1.x is servlet-api 6.
There was a problem hiding this comment.
We are aiming for Tomcat 10.1 and Jetty 12 support, so I think we should migrate to Jakarta EE 10.
There was a problem hiding this comment.
In that case we have some references to Jetty 11.0.25 in this PR that will need to be updated to 12.0.23
There was a problem hiding this comment.
Unfortunately Jetty 12.0.23 supports min JDK 17 version, so I think we should upgrade to Jakarta EE 9 for now. 3ea1189
…sion and use Max-Age cookie attribute)
vharseko
force-pushed
the
master
branch
2 times, most recently
from
2e23d97 to
35b7528
Compare
vharseko
changed the title
vharseko
force-pushed
the
master
branch
3 times, most recently
from
c250271 to
5ac80c3
Compare
3 participants
Uh oh!
There was an error while loading. Please reload this page.