Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
- Coverage 76.59% 76.58% -0.01%
==========================================
Files 608 608
Lines 45386 45381 -5
Branches 798 798
==========================================
- Hits 34764 34757 -7
- Misses 10534 10536 +2
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmthomas
commented
Aug 23, 2024
| .question { | ||
| font-size: 1rem; | ||
| white-space: pre-line; | ||
| } | ||
| </sytle> | ||
| </style> |
| @@ -77,7 +76,7 @@ def set(name:, value:, type: nil, unit: nil, help: nil, labels: nil, time_ms: ni | |||
| end | |||
|
|
|||
| def set_multiple(data) | |||
| @mutex.synchonize do | |||
| @mutex.synchronize do | |||
ryanmelt
requested changes
Aug 26, 2024
Member
ryanmelt
left a comment
ryanmelt
left a comment
There was a problem hiding this comment.
That's a lot of spelling errors!
One spelling error still "discret" is French.
Also please add a spell checker to our CI/CD pipeline so that these don't start building up again.
| - Script Runner allows for running OpenC3 COSMOS test procedures or any other Ruby code from a graphical environment that highlights each line as it executes. At anytime during execution, the script can be paused or stopped. If a telemetry check fails or any other exception occurs, the script is immediately stopped and the user notified. | ||
|
|
||
| - Script Runner also allows you to break your operational or test procedures down into discreet test cases that each complete with either SUCCESS or FAILURE. After running, a script report is automatically created for you. Convenient features such as the ability to loop testing help get the kinks out of your system before formal runs. | ||
| - Script Runner also allows you to break your operational or test procedures down into discret test cases that each complete with either SUCCESS or FAILURE. After running, a script report is automatically created for you. Convenient features such as the ability to loop testing help get the kinks out of your system before formal runs. |
Contributor
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (1187)Some files were automatically ignored 🙈These sample patterns would exclude them: You should consider excluding directory paths (e.g. You should consider adding them to: File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct and update file exclusions, you could run the following commands... in a clone of the git@github.com:OpenC3/cosmos.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/OpenC3/cosmos/actions/runs/10565974963/attempts/1'Available 📚 dictionaries could cover words not in the 📘 dictionary
Consider adding them (in with:
extra_dictionaries:
cspell:aws/aws.txt
cspell:css/dict/css.txt
cspell:filetypes/filetypes.txt
cspell:node/dict/node.txt
cspell:php/dict/php.txtTo stop checking additional dictionaries, add (in check_extra_dictionaries: ''Errors (6)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. |
|
ryanmelt
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.