Build in statically linked libssh2 for openssl1.1#11
Open
eddymoulton wants to merge 7 commits into
Open
Conversation
eddymoulton
changed the title
eddymoulton
commented
May 8, 2026
Comment on lines
+15
to
+16
| RID: ${{ matrix.rid }} | ||
| VARIANT: ${{ matrix.variant }} |
Collaborator
Author
There was a problem hiding this comment.
We explicitly build openssl1.1 variants where needed (only linux targets)
liam-mackie
approved these changes
May 12, 2026
liam-mackie
left a comment
liam-mackie
left a comment
There was a problem hiding this comment.
LGTM from a review perspective. By god it's a complicated build architecture though.
| uses: actions/download-artifact@v8.0.1 | ||
| with: | ||
| path: nuget.package/runtimes/ | ||
| - name: Merge variant artifacts into RID directories |
There was a problem hiding this comment.
Nit: this bash, while working (and dense) reads like code golf. Possibly worth adding a small comment around exactly what we expect this to do in a future PR (if this survives the test of time, I'll be seen as a good reviewer)
| @@ -0,0 +1,34 @@ | |||
| ARG BASE_IMAGE=debian:bookworm-slim | |||
There was a problem hiding this comment.
Nit: use what we always use for the actual build?
Suggested change
| ARG BASE_IMAGE=debian:bookworm-slim | |
| ARG BASE_IMAGE=debian:bullseye-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a requirement to support targets still running OpenSSL1.1 for at least another 4 months.
Since we preference OpenSSL3, this will remain the default pathway. But we also build a fully contained OpenSSL1.1 version that can be used where needed. LibGit2Sharp will determine which binaries to load in depending on the host.
I've chosen to statically link libssh2 for only OpenSSL1.1 so we retain the previous solution for the OpenSSL3 path, which has a much simpler build process. This change isn't what we want to keep long term, but is required for now.