URL redirect and ValidateIssuer CodeQL bugs#9398
Merged
Conversation
drewgillies
previously approved these changes
Feb 22, 2023
agr
reviewed
Feb 22, 2023
agr
reviewed
Feb 22, 2023
…the suppression comment to reflect this as the mitigation for the vulnerability.
agr
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/NuGet/Engineering/issues/4790
Part of https://github.com/NuGet/Engineering/issues/4593
This PR addresses 4 NuGetGallery CodeQL issues.
System.Net.Http.HttpClient. (Bug #1632800)
the ValidateIssuer flag in our AAD auth. When Issuer Validation is turned on, the issuer in the token is compared
against a list of accepted tenants. (Bug #1632802)
flag off. Added a suppression comment.