devel/patch: security fixes - #33
Closed
AttilaFueloep wants to merge 3 commits into
Closed
Conversation
Member
|
Hello Attila,
Attila Fülöp writes:
Fixes CVE-2018-6951, CVE-2018-6952 and CVE-2018-1000156.
You can view, comment on, or merge this pull request online at:
#33
-- Commit Summary --
* devel/patch: security fixes
-- File Changes --
M devel/patch/Makefile (8)
M devel/patch/distinfo (4)
A devel/patch/patches/patch-config.hin (20)
Is patch-config.hin really needed? In the configure phase it seems
that now all the HAVE_* are checked also without the patch and
config.h is then populated properly after the `configure' phase.
I think that patch-config.hin is not needed.
According `cvs annotate' it seems that the change was part of
`devel/patch/Makefile -r1.42' reported via PR pkg/49672 and indeed
it seems that it was applied upstream, so we can just remove
patch-config.hin.
[...]
Thank you!
|
bsiegert
suggested changes
Oct 18, 2018
bsiegert
left a comment
bsiegert
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this! Just one comment regarding the Makefile.am patch.
| @@ -0,0 +1,14 @@ | |||
| $NetBSD$ | |||
Contributor
There was a problem hiding this comment.
Will this actually have any effect? It does not look as if you re-run automake. Maybe this change needs to be in Makefile.in?
Author
There was a problem hiding this comment.
Doh, of course, sorry for the confusion. Fixed
Author
|
@iamleot Good catch. Builds fine on SmartOS without, so I removed the |
Member
|
Hello Attila,
Attila Fülöp writes:
@iamleot Good catch. Builds fine on SmartOS without, so I removed the `config.hin>` patch.
Thank you!
They are now committed!
|
Author
|
It's been a pleasure. Closing. |
Author
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CVE-2018-6951, CVE-2018-6952 and CVE-2018-1000156.