feature/CSTACKEX-223: Cloudstack CICD pipeline - #98
Open
sandeeplocharla wants to merge 13 commits into
Open
sandeeplocharla wants to merge 13 commits into
sandeeplocharla wants to merge 13 commits into
Conversation
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.60% |
| Branch coverage | 18.77% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.59% |
| Branch coverage | 18.76% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.59% |
| Branch coverage | 18.76% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sandeeplocharla
changed the title
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.60% |
| Branch coverage | 18.77% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sandeeplocharla
requested review from
piyush5netapp,
rajiv-jain-netapp,
sathvikaragi,
suryag1201 and
vallikns
September 2, 2026 07:18
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.59% |
| Branch coverage | 18.76% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
sandeeplocharla
force-pushed
the
feature/CSTACKEX-223
branch
from
September 7, 2026 07:32
457b2bd to
5ed00e6
Compare
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.59% |
| Branch coverage | 18.76% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
A refused Check Run only logged the curl exit code, so GitHub's reason stayed hidden and reproducing it cost a full worker run of over an hour. Print GitHub's message, errors, and documentation link on failure, and add SOURCE_MODE=diagnose to probe token type, repository access, Checks read, and one Checks write in seconds. Also record that NetApp's CI/CD in Github guide grants Commit statuses rather than the Checks permission a Check Run needs, which is why an App built from that guide reads pull requests fine but cannot publish.
sandeeplocharla
force-pushed
the
feature/CSTACKEX-223
branch
from
September 8, 2026 01:22
5ed00e6 to
25bb076
Compare
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.60% |
| Branch coverage | 18.77% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
rajiv-jain-netapp
approved these changes
Sep 21, 2026
suryag1201
approved these changes
Sep 29, 2026
vallikns
reviewed
Sep 30, 2026
| @@ -0,0 +1,225 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Rename the file name to meaningful name instead of phase2.
| # Optional: PR_ID and BUILD_TAG label the check run. | ||
| # Called by the Jenkinsfile. Does not call other private-cicd scripts. | ||
|
|
||
| set -euo pipefail |
There was a problem hiding this comment.
-e is not required, handle the error explicitly instead of abrupt failure. Please add try catch block or common error block to log the errors with graceful failure.
| @@ -0,0 +1,91 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
What is difference between list-eligible-prs vs test_list_eligible_prs?
vallikns
reviewed
Sep 30, 2026
| @@ -0,0 +1,105 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
General comments (post PR, you can handle it).
- Use multibranch pipeline.
- Rename the file according to the code context instead of phase names.
- Change the frequency from 5Mins to 30Mins
Right now, code is good to commit and enable it for the dry run.
Additional points,
- For code coverage, we have to use our own runners instead of Github native due to security concerns. We can check with support as well.
We will let you know the best practices, which we are constructing from the Hyper-V DevOps work.
vallikns
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has changes to bring up CICD pipeline for Cloudstack
https://netapp.atlassian.net/wiki/spaces/OSSG/pages/689709001/CloudStack+NetApp+ONTAP+CI+CD+Pipeline
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Successful End-to-End build URL: https://virtualization-jenkins.daas.netapp.com/job/cloudstack-ontap-presubmit/121/console
Presubmit start mailPresubmit Success mailPresubmit Failure mail