Skip to content

bugfix/CSTACKEX-169: Fix enum case sensitive issues #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piyush5netapp merged 3 commits into from
May 5, 2026
+10 −2
Merged

bugfix/CSTACKEX-169: Fix enum case sensitive issues #53

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b90542f
bugfix/CSTACKEX-169: Fix enum case sensitive issues
Apr 28, 2026
0ef0206
bugfix/CSTACKEX-169: Added NPE for b.value
May 4, 2026
0ddd85b
bugfix/CSTACKEX-169: remove unwanted change
May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .../storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Igroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@

package org.apache.cloudstack.storage.feign.model;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonValue;

import java.util.List;
import java.util.Objects;
Expand Down Expand Up @@ -71,6 +73,7 @@ public enum OsTypeEnum {
this.value = value;
}

@JsonValue
public String getValue() {
return value;
}
Expand All @@ -80,9 +83,11 @@ public String toString() {
return String.valueOf(value);
}

@JsonCreator
public static OsTypeEnum fromValue(String text) {
if (text == null) return null;
for (OsTypeEnum b : OsTypeEnum.values()) {
if (String.valueOf(b.value).equals(text)) {
if (text.equalsIgnoreCase(b.value)) {
return b;
}
}
Expand Down Expand Up @@ -122,6 +127,7 @@ public enum ProtocolEnum {
this.value = value;
}

@JsonValue
public String getValue() {
return value;
}
Expand All @@ -131,9 +137,11 @@ public String toString() {
return String.valueOf(value);
}

@JsonCreator
public static ProtocolEnum fromValue(String text) {
if (text == null) return null;
for (ProtocolEnum b : ProtocolEnum.values()) {
if (String.valueOf(b.value).equals(text)) {
if (text.equalsIgnoreCase(b.value)) {
Comment thread
piyush5netapp marked this conversation as resolved.
return b;
}
}
Expand Down
Loading