feat(testing): add mocha and jasmine patch outputs for nativescript [DO NOT MERGE]#2
Closed
justindujardin wants to merge 1 commit intoNativeScript:zone-nativescriptfrom
justindujardin:testing-exports
Closed
feat(testing): add mocha and jasmine patch outputs for nativescript [DO NOT MERGE]#2justindujardin wants to merge 1 commit intoNativeScript:zone-nativescriptfrom justindujardin:testing-exports
justindujardin wants to merge 1 commit intoNativeScript:zone-nativescriptfrom
justindujardin:testing-exports
Conversation
justindujardin
commented
Jan 9, 2018
justindujardin
commented
- add gulp build tasks for mocha/jasmine testing files for {N}
- there are three files in nativescript-angular/zone-js/dist now. The dist file, and a file to include when doing angular testing with jasmine as well as one to include for mocha testing.
- update mocha patch to be tolerant of envs {N} where there is no global window object.
- run updated tests and disable ones with platform incompatibilities
- add gulp build tasks for mocha/jasmine testing files for {N}
- there are three files in nativescript-angular/zone-js/dist now. The dist file (which is updated to 0.8.18) and a file to include when doing angular testing with jasmine as well as one to include for mocha testing.
- update mocha patch to be tolerant of envs {N} where there is no global window object.
- run updated tests and disable ones with platform incompatibilities
justindujardin
changed the title
Author
|
I'm seeing weird behavior trying to test this locally, debugging.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.