Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

watchLocation errorCallback not being used #195

Open

Description

@Vallhay

In geolocation.js, line 150 the value of the watchLocation error callback is assigned to a var but then is never used. Im not sure if the watchLocation errorCallback is being call

Activity

  1. tbozhikov commented on Feb 7, 2019

    @tbozhikov
    Contributor

    Hi @Faguaz, thanks for reporting! Indeed, in Android, the errorCallback of the watchLocation() method seems to never be called (see this line).
    It would be best to research if errors in watching location in Android can occur and call this callback if such is caught. Otherwise, the declaration

    const zonedErrorCallback = zonedCallback(errorCallback);

    ... can be removed.
    We love pull requests, so if you have any ideas regarding this, feel free to contribute (make sure you assign this issue to yourself in this case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions