fix: don't show warnings for non-nativescript plugins on tns preview --bundle command#3958
Merged
Merged
Conversation
… --bundle` command
rosen-vladimirov
approved these changes
Oct 1, 2018
Contributor
rosen-vladimirov
left a comment
There was a problem hiding this comment.
We should also suggest the users to use Webpack in case they are not using it at the moment and have plugins without native code that are not available in the Preview app.
Contributor
Author
|
run ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Warning is shown for non nativescript plugins on
tns preview --bundlecommandWhat is the new behavior?
Warning is not shown for non nativescript plugins on
tns preview --bundlecommand