Skip to content

fix: don't show warnings for non-nativescript plugins on tns preview --bundle command#3958

Merged
Fatme merged 1 commit into
masterfrom
fatme/preview-js-plugin-warnings
Oct 2, 2018
Merged

fix: don't show warnings for non-nativescript plugins on tns preview --bundle command#3958
Fatme merged 1 commit into
masterfrom
fatme/preview-js-plugin-warnings

Conversation

@Fatme
Copy link
Copy Markdown
Contributor

@Fatme Fatme commented Oct 1, 2018

PR Checklist

What is the current behavior?

Warning is shown for non nativescript plugins on tns preview --bundle command

What is the new behavior?

Warning is not shown for non nativescript plugins on tns preview --bundle command

Copy link
Copy Markdown
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also suggest the users to use Webpack in case they are not using it at the moment and have plugins without native code that are not available in the Preview app.

@Fatme
Copy link
Copy Markdown
Contributor Author

Fatme commented Oct 2, 2018

run ci

@Fatme Fatme merged commit c51da02 into master Oct 2, 2018
@Fatme Fatme deleted the fatme/preview-js-plugin-warnings branch October 2, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants