Conversation
tailsu
force-pushed
the
sd/karma
branch
2 times, most recently
from
October 6, 2015 14:04
7c24c49 to
18edb5e
Compare
Contributor
There was a problem hiding this comment.
Please use ES6 compatible imports where possible
Contributor
|
Running this code produced I recommend that we do not require for the CLI to be in the PATH, which is a breaking change and stops the users and QAs from using the CLI locally. |
tailsu
force-pushed
the
sd/karma
branch
2 times, most recently
from
October 13, 2015 13:47
6c9d144 to
af1962a
Compare
Contributor
Author
|
No more manual steps. Just check out the branch and all testing commands should just work. |
Contributor
There was a problem hiding this comment.
I suggest to make this message more visible - perhaps using yellow color.
Contributor
Author
|
The unit test runner should be installed as a plugin, not in this hacky way. I'm going to fix that, so sit tight for more commits. |
tailsu
force-pushed
the
sd/karma
branch
2 times, most recently
from
October 15, 2015 12:47
1a9a69a to
8194a2a
Compare
|
Test PASSed. |
|
Test PASSed. |
Contributor
|
👍 |
|
Test PASSed. |
|
Test FAILed. |
* install and serve testing framework dependencies * jasmine and mocha support * respect --watch option in tns test * pass $config.DEBUG to karma server * support for ios simulator * exclude tests/ folder from release builds * documentation for test commands * pass log level and --path if specified to karma * pass path to node executable and path to nativescript cli entry point to karma * '--framework' option for `tns test init` * deploy unit test runner as tns plugin * option to debug socket.io in unit test runner
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test FAILed. |
tailsu
added a commit
that referenced
this pull request
Oct 20, 2015
`test init` and `test android|ios` commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit testing support for nativescript