fix(forms): add directives for formControl#861
Merged
sis0k0 merged 1 commit intoNativeScript:masterfrom Jun 23, 2017
Merged
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Contributor
|
run ci |
Contributor
Author
|
Thanks for merging so quickly. Any idea when the next release is scheduled? Need this functionality for a project I am currently working on. |
sis0k0
pushed a commit
that referenced
this pull request
Jun 26, 2017
sis0k0
added a commit
that referenced
this pull request
Jun 26, 2017
sis0k0
added a commit
that referenced
this pull request
Jun 26, 2017
Contributor
|
Heya, the fix is available when using the |
sis0k0
added a commit
that referenced
this pull request
Jun 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Somewhat related to #576 and #526
At the moment, selectors only apply to
ngModelandformControlNamemeaning for Angular reactive forms to work with inputs, they must useformControlNamewithin aformGroupdirective.I would like to add
[formControl]to the list of selectors so that reactive forms can be used without a parentformGroup.Rationale:
Say you have a dumb component which implements an input:
Which is used by some parent component:
The above does not work with the latest
nativescript-angularwith the following error: "No value accessor for form control with unspecified name attribute".Adding the directives in the PR makes the above example work.