fix(renderer): set templateParent to comment and text nodes#785
Merged
fix(renderer): set templateParent to comment and text nodes#785
Conversation
DetachedText is not inserted in the UI components tree, so we need to add it's parent manually.
sis0k0
force-pushed
the
vlaeva/renderer-fixes
branch
from
2ac42a0 to
a1ff6c7
Compare
sis0k0
force-pushed
the
vlaeva/renderer-fixes
branch
from
7964d08 to
24161e7
Compare
sis0k0
force-pushed
the
vlaeva/renderer-fixes
branch
from
24161e7 to
108e4d0
Compare
sis0k0
changed the title
sis0k0
changed the title
vakrilov
approved these changes
May 9, 2017
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When createText() method of the renderer is called, the newly created CommentNode elements (plain JS objects) are not attached to the visual elements tree.
However, we set a
templateParentto them in the insertChild method and return it instead of parent in the parentNode method.Changes:
meta: skipAddToDomandtemplateParentare created both for text nodes and comment nodes in the renderer.element-types.ts