Enable TestBed in nativescript#730
Enable TestBed in nativescript#730hypery2k wants to merge 11 commits intoNativeScript:masterfrom hypery2k:master
Conversation
|
This looks like it's related to #733 , yet it doesn't seem to touch the setGlobalVar implementation, so I'll assume it doesn't fix that issue. |
| @@ -0,0 +1,19 @@ | |||
| require("reflect-metadata"); | |||
| require("nativescript-angular/zone-js/dist/zone-nativescript"); | |||
| require("zone.js/dist/long-stack-trace-zone"); | |||
There was a problem hiding this comment.
NativeScript bundles its own version of zone.js, and requiring zone.js from the npm looks fishy. You could easily end up with two separate zone implementations and that will likely break things. I suggest we use nativescript-angular/zone-js everywhere.
There was a problem hiding this comment.
Does this mean that you also want to include the jasmine-patch + mocha-patch for unit testing? Those are currently necessary to run our tests and they're not included in nativescript-angular/zone-js.
There was a problem hiding this comment.
@hdeshev should i create a PR at nativescript-angular/zone-js?
| } | ||
| require("zone.js/dist/async-test"); | ||
| require("zone.js/dist/fake-async-test"); | ||
| var testing_1 = require("@angular/platform-browser-dynamic/testing"); |
There was a problem hiding this comment.
This looks like code transpiled from TypeScript. Why not implement it in TypeScript instead?
There was a problem hiding this comment.
i started with TypeScript, but had some issues with module dependencies, but will check it again
#comment nodes should be added as views to 'actionBar' since they are anchors for the elements added by structural directive (*ngIf, *ngFor, etc.) closes #725
The fix was not taking into account that view were being recycled and was causing crashes due to prematurely destroying item views.
Instantiate child injectors with a providers' map for outlet specific providers such as Page, PageRoute, ActivatedRoute, etc. fixes #741
* Update package.json to v3.0.0 * Update description field * Update CHANGELOG.md * More deps and readme changes
|
I think I will rebase my fork and make a new PR, or? |
|
Yes, that will be good, thank you :) |
4 participants
Fixes #478, #479 and #584
Currently having issues that the setup for TestBed is working, but other tests are failing:
If I use it standalone all is working fine. Should I add a new test app for that?