fix: revert recursive remove -causing crashes#1819
Merged
Conversation
ghost
assigned
Contributor
|
test sdk_ng |
Contributor
|
test sdk_ng |
SvetoslavTsenov
approved these changes
May 13, 2019
Contributor
|
I think, i know what causes this. I removed the test for Span and FormattedString, thinking isDetachedView would handle it. |
Contributor
Author
|
I have fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverting the recursive removeChild implemented in #1740 by @m-abs
We found the following issues and decided to revert the change until they are resolved:
Cannot read property 'textTransform' of undefinedincreateSpannableStringBuilder. Already PR intns-core-modulesTabView->Basic->[back]. You get a crash (in console) and cannot navigate any more