release: cut the 7.2.4 release#1790
Closed
SvetoslavTsenov wants to merge 51 commits intoreleasefrom
Closed
Conversation
…on-7.3.0 chore: bump package versino tp 7.3.0
Merge release in master
* fix(router): routing services should be provided in forRoot only * refactor: remove logs * refactor: use single return statment in forRoot/Child
Myankov/merge release master
chore: merge release in master
…escript-angular into fix/923-module-not-destroyed
fix(location-strategy): crash on going back with router-outlet after closing modal
If exit event was triggered twice we would try to destroy an already destroy module ref.
…escript-angular into fix/923-module-not-destroyed
The usage of short imports, e.g, `import * as Page from "ui/page"`
instead of `import * as Page from "tns-core-modules/ui/page"` is
*deprecated* since {N} 5.2.
Don't destroy the angular module on restart
NS Angular - API Ref Build
feat(modal): expose current/future core options via ModalDialogParams
chore(list-view): rename the new options API and change its type
Update modal to allow use of ios presentationStyle
chore: merge release in master
refactor: minor changes after review
fix(NativeScriptPlatformRef): Destroy lastModuleRef on exitEvent
…s-resolution chore(tsconfig): remove path resolution for short imports (`ui/page`)
ghost
assigned
elena-p
reviewed
Apr 23, 2019
| ### Bug Fixes | ||
|
|
||
| * **router:** routing services should be provided in forRoot only ([#1729](https://github.com/NativeScript/nativescript-angular/issues/1729)) ([0f6a975](https://github.com/NativeScript/nativescript-angular/commit/0f6a975)) | ||
| * on destroy remove the lastBootstrappedModule ([5e13263](https://github.com/NativeScript/nativescript-angular/commit/5e13263)) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.