Skip to content

fix(router): fix return value for getTransition of NSRouterLink#1787

Merged
VladimirAmiorkov merged 3 commits intoNativeScript:masterfrom
flore2003:router-link-fix
May 16, 2019
Merged

fix(router): fix return value for getTransition of NSRouterLink#1787
VladimirAmiorkov merged 3 commits intoNativeScript:masterfrom
flore2003:router-link-fix

Conversation

@flore2003
Copy link
Copy Markdown
Contributor

@flore2003 flore2003 commented Apr 20, 2019

Return undefined transition value from getTransition method of NSRouterLink when boolean value is used for pageTransition input. Fixes #1784

PR Checklist

What is the current behavior?

The getTransition method of NSRouterLink returns an empty object value for the transition property, when the ´pageTransition´ input is given a boolean value. This leads to the defaultTransition of the Frame not being applied.

What is the new behavior?

The getTransition method of NSRouterLink now returns undefined as the value for the transition property.

Fixes #1784.

Return undefined transition value from getTransition method of NSRouterLink when boolean value is used for pageTransition input. Closes #1784
@flore2003
Copy link
Copy Markdown
Contributor Author

Any news on this PR?

@VladimirAmiorkov
Copy link
Copy Markdown
Contributor

Hi @flore2003 ,

The PR has been reviewed but is not yet merged because we are in the process of a release which is planned for later this week. After that release we will update this PR to the latest branch and process it. Sorry for the delay caused by our current release plan.

@VladimirAmiorkov VladimirAmiorkov merged commit 1629feb into NativeScript:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default transition of Frame is not used when using NsRouterLink

3 participants