Refactor modal options to expose current/future core options#1769
Closed
edusperoni wants to merge 2 commits into
Closed
Refactor modal options to expose current/future core options#1769edusperoni wants to merge 2 commits into
edusperoni wants to merge 2 commits into
Conversation
5 tasks
Contributor
|
Hi @edusperoni , Thank you for your contribution with this PR and the comments on the #1767 PR. As I see that your PR's code changes have been taken and added to the #1767 PR and as it also contains additional functionality in the form of the new |
Collaborator
Author
|
I don't really care which PR is merged, but that PR is still using the |
Contributor
|
@edusperoni yes I have noticed that, it also is missing a "test" case example. We are going to process it. |
5 tasks
Contributor
|
Closing in favor of #1771 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The current exposed options for showModal differs from the options available in the core.
What is the new behavior?
All current and future non-angular options are exposed by leveraging Typescript's
Picktype.#1767 attempts to fix this, but another property has been exposed (
android: any), so other PRs would be needed for every new property.I'm asking for this PR to be considered over #1767
Fixes #1709.