fix(forms): Changed the TextValueAccessor to apply ng-touched on blur#1230
Merged
manoldonev merged 3 commits intoNativeScript:masterfrom Jul 24, 2018
Merged
fix(forms): Changed the TextValueAccessor to apply ng-touched on blur#1230manoldonev merged 3 commits intoNativeScript:masterfrom
manoldonev merged 3 commits intoNativeScript:masterfrom
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
hgmich
added a commit
to MelonWD/nativescript-angular
that referenced
this pull request
Apr 17, 2018
|
this PR would fix "TextField having wrong value if updateOn: 'blur'" 👍 https://github.com/angular/angular/blob/master/packages/forms/src/directives/control_value_accessor.ts |
Contributor
|
test |
manoldonev
approved these changes
Jul 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The moment a TextField or TextView is touched the onTouched() function is called on the valueAccessor. This changes the ng-untouched class to ng-touched. See #1063 and Playground Demo
What is the new behavior?
The TextValueAccessor now waits for the blur event before marking the field as touched.
This is the angular-core behavior as can be seen here.
Fixes #1063, #804.