feat: Angular 4.4 support by vakrilov · Pull Request #1002 · NativeScript/nativescript-angular

vakrilov · 2017-09-21T13:00:48Z

In this PR:

Bumped dependencies to angular@4.4.x
Implemented NsHttpBackEnd that handles local requests made with HttpClient service
Minor 4.4 updates

Resolves #966
Resolves #1001

vakrilov · 2017-09-21T13:46:45Z

uitests

sis0k0 · 2017-09-26T07:46:08Z

    "id": "org.nativescript.renderer",
    "tns-android": {
-      "version": "next"
+      "version": "3.2.0-2017-9-12-1"


was this intentional?

sis0k0 · 2017-09-26T11:17:45Z

+    return url.indexOf("~") === 0 || url.indexOf("/") === 0;
 }

 function normalizeLocalUrl(url: string): string {


This method can be reused in NsHttpBackEnd

sis0k0 · 2017-09-26T11:18:59Z

+    }
 }

 function isLocalRequest(url: string): boolean {


This is duplicated in NsHttpBackEnd. May be a good idea to extract it in a common module?

sis0k0 · 2017-09-26T11:21:33Z

+        return url;
+    }
+
+    private handleLocalRequest(url: string): Observable<HttpEvent<any>> {


This seems to be the same as _requestLocalUrl from NSHttp except the additional error handling for failed parsing. Can we move the method to a common module (with the error handling)?

sis0k0 · 2017-09-26T11:23:23Z

+                            const json = JSON.parse(data);
+                            observer.next(createSuccessResponse(url, json, 200));
+                            observer.complete();
+                        } catch (error) {


Catch only SyntaxErrors?

sis0k0 · 2017-09-26T11:24:36Z

+import { NSFileSystem } from "../file-system/ns-file-system";
+import { NsHttpBackEnd } from "./ns-http-backend";
+
+export { NsHttpBackEnd } from "./ns-http-backend";


Why is that reexported from here?

sis0k0 · 2017-09-26T11:43:26Z

+    HttpClient, HTTP_INTERCEPTORS, HttpEventType, HttpErrorResponse,
+    HttpEvent, HttpInterceptor, HttpHandler, HttpRequest
+} from "@angular/common/http";
+import { Observable } from "rxjs/observable";


from "rxjs/observable" -> from "rxjs/Observable"

SvetoslavTsenov · 2017-10-02T15:29:30Z

e2e

vakrilov · 2017-10-03T12:43:36Z

e2e

sis0k0

Remove e2e/router/.vscode dir. Rebasing on top of master may resolve that.

sis0k0 · 2017-10-03T16:20:08Z

+        return result;
+    }
+
+    private handleLocalRequest(url: string): Observable<HttpEvent<any>> {


The name of the method is a bit confusing as it matches the name of the imported function.

sis0k0 · 2017-10-03T16:20:34Z


-function normalizeLocalUrl(url: string): string {
-  return url.replace("~", "").replace("/", "");
+    private handleLocalRequest(url: string): Observable<Response> {


Same as above

…rHandler

…ient" module.

…pium

vchimev · 2017-10-06T06:39:29Z

renderer-android

jogboms · 2017-10-11T15:34:42Z

@vakrilov

ERROR Error: Uncaught (in promise): Error: com.tns.NativeScriptException: Failed to find module: "nativescript-angular/value-accessors/base-value-accessor", relative to: app/tns_modules/

Just installed @next

@angular/*: "^4.4.1"

Narrowed it down to nativescript-drop-down.

I believe we would get some breaking change all-round. Reverting now until a list is ready. 😄

jogboms · 2017-10-11T15:51:06Z

I can see nativescript-angular/value-accessors has been moved to nativescript-angular/forms/value-accessors

jogboms · 2017-10-12T01:25:07Z

nativescript-angular/common/utils no longer exists as well

vakrilov · 2017-10-12T08:55:57Z

Hey @jogboms, thanks for reporting that!
Actually, the nativescript-angular/common/utils was removed a few releases back (before 4.x).
We heave moved the value-accessors inside the forms in this PR(#1003) which is a breaking change for plugins/apps that import it. We are currently working on a patch with a fix.

jogboms · 2017-10-12T08:58:55Z

Okay. Didn't notice that. Just sent a PR over. Quick question tho, does v4.4 require the @next version tns-core-modules

vchimev · 2017-10-12T13:41:33Z

Hey @jogboms,
nativescript-angular@4.4 does not require tns-core-modules@next, however, it works with both latest and next versions.

jogboms · 2017-10-12T14:14:01Z

Very well @vchimev. Thanks.

vchimev · 2017-10-13T10:47:24Z

nativescript-angular@4.4.1 containing a compatibility fix has been released - here is the changelog.

jogboms · 2017-10-13T11:52:02Z

Nice one. 👍 @vchimev

vakrilov requested a review from sis0k0 September 21, 2017 13:00

ghost assigned vakrilov Sep 21, 2017

ghost added the in progress label Sep 21, 2017

vakrilov mentioned this pull request Sep 21, 2017

chore(cleanup): Repo cleanup #1003

Merged

sis0k0 reviewed Sep 26, 2017

View reviewed changes

vakrilov force-pushed the ng44 branch from 557510e to 3efe386 Compare October 3, 2017 12:42

sis0k0 reviewed Oct 3, 2017

View reviewed changes

sis0k0 approved these changes Oct 4, 2017

View reviewed changes

vakrilov and others added 14 commits October 5, 2017 21:41

chore(update): Update deps to angular 4.4.1

3e131f2

chore(update): Replace OpaqueTokens with InjectionTokens.

c640b7c

chore(update): Stop passing any arguments to the constructor for Erro…

3beea35

…rHandler

chore(update): Update apps deps

9c298cc

feat(http): Support for HttpClinet with "nativescript-angular/http-cl…

9c8da72

…ient" module.

test(http): Add tests for NsHttpBackEnd

58dd8fb

chore(cleanup): Remove unused imports

74511b0

fix: Fixed runt

bfd0d97

Update test to be compatible with next version of nativescript-dev-ap…

fa6381b

…pium

Upade vs settings and .gitignore

4a81f08

refactor: Minor changes based on PR review

3f11eeb

refactor: Extract common http methods

1d1877e

chore: Removing .vscode folder form rotuer tests

1ad18cc

refactor: Renamed some methods for clarity

f8dfb2a

vakrilov force-pushed the ng44 branch from 919777b to f8dfb2a Compare October 5, 2017 18:59

vakrilov merged commit c264453 into master Oct 6, 2017

NativeScript deleted a comment from vakrilov Oct 6, 2017

vakrilov deleted the ng44 branch October 12, 2017 08:47

ADjenkov removed the in progress label Nov 2, 2017

Uh oh!

Conversation

vakrilov commented Sep 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vakrilov commented Sep 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SvetoslavTsenov commented Oct 2, 2017

Uh oh!

vakrilov commented Oct 3, 2017

Uh oh!

sis0k0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vchimev commented Oct 6, 2017

Uh oh!

jogboms commented Oct 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jogboms commented Oct 11, 2017

Uh oh!

jogboms commented Oct 12, 2017

Uh oh!

vakrilov commented Oct 12, 2017

Uh oh!

jogboms commented Oct 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vchimev commented Oct 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jogboms commented Oct 12, 2017

Uh oh!

vchimev commented Oct 13, 2017

Uh oh!

jogboms commented Oct 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vakrilov commented Sep 21, 2017 •

edited

Loading

jogboms commented Oct 11, 2017 •

edited

Loading

jogboms commented Oct 12, 2017 •

edited

Loading

vchimev commented Oct 12, 2017 •

edited

Loading