Skip to content

fix(text-view): only reload text if hint is showing on ios #8662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 2 commits into from
Jun 30, 2020
Merged

fix(text-view): only reload text if hint is showing on ios #8662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
830b012
fix(text-view): only reload text if hint is showing on ios
dosomder Jun 22, 2020
3bca8cc
Merge branch 'master' into fix-ios-text-view-reloading
NathanWalker Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nativescript-core/ui/text-view/text-view.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class NoScrollAnimationUITextView extends UITextView {
export class TextView extends TextViewBaseCommon {
nativeViewProtected: UITextView;
private _delegate: UITextViewDelegateImpl;
private _isShowingHint: boolean;
_isShowingHint: boolean;
public _isEditing: boolean;

private _hintColor = (majorVersion <= 12 || !UIColor.placeholderTextColor) ? UIColor.blackColor.colorWithAlphaComponent(0.22) : UIColor.placeholderTextColor;
Expand Down Expand Up @@ -129,7 +129,9 @@ export class TextView extends TextViewBaseCommon {
}

public textViewShouldBeginEditing(textView: UITextView): boolean {
this.showText();
if (this._isShowingHint) {
this.showText();
}

return true;
}
Expand Down