fix(text-view): only reload text if hint is showing on ios#8662
Merged
NathanWalker merged 2 commits intoNativeScript:masterfrom Jun 30, 2020
Merged
fix(text-view): only reload text if hint is showing on ios#8662NathanWalker merged 2 commits intoNativeScript:masterfrom
NathanWalker merged 2 commits intoNativeScript:masterfrom
Conversation
dosomder
force-pushed
the
fix-ios-text-view-reloading
branch
from
21d2682 to
615b6ec
Compare
dosomder
force-pushed
the
fix-ios-text-view-reloading
branch
from
615b6ec to
830b012
Compare
Contributor
Author
|
@NathanWalker rebased on master to fix merge conflicts |
Contributor
|
Thanks @dosomder |
NathanWalker
approved these changes
Jun 26, 2020
Contributor
Author
|
@NathanWalker Do you know when this is planned to be merged / released? |
Contributor
|
This will go out this week in a patch update 👍 |
Contributor
Author
|
Looking forward to the release 👍 |
Contributor
|
Released with https://github.com/NativeScript/NativeScript/releases/tag/6.5.9 now |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
tarunama
pushed a commit
to tarunama/NativeScript
that referenced
this pull request
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
iOS TextView reloads text every time the TextView is focused
What is the new behavior?
Only reload text if necessary (i.e. previously was the hint shown)
Fixes/Implements/Closes #8620