Skip to content

Update actions/setup-java@v5 [skip ci]#14024

Merged
pxLi merged 1 commit intoNVIDIA:mainfrom
pxLi:update-setup-java-v5
Dec 17, 2025
Merged

Update actions/setup-java@v5 [skip ci]#14024
pxLi merged 1 commit intoNVIDIA:mainfrom
pxLi:update-setup-java-v5

Conversation

@pxLi
Copy link
Copy Markdown
Member

@pxLi pxLi commented Dec 17, 2025

Summary

Upgrade GitHub Actions to their latest versions to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Changes

Action Old Version(s) New Version Release Files
actions/setup-java v4 v5 Release blossom-ci.yml

Context

Per GitHub's announcement, Node 20 is being deprecated and runners will begin using Node 24 by default starting March 4th, 2026.

NOTE: Blossom-ci integrity check has been updated to cover this change internally

Signed-off-by: Peixin Li <pxLi@nyu.edu>
@pxLi pxLi requested a review from a team as a code owner December 17, 2025 00:48
@pxLi pxLi self-assigned this Dec 17, 2025
@pxLi pxLi added the build Related to CI / CD or cleanly building label Dec 17, 2025
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Dec 17, 2025

Greptile Overview

Greptile Summary

Updated actions/setup-java from v4 to v5 across all GitHub Actions workflows to ensure compatibility with Node 24, as Node 20 will reach end-of-life in April 2026.

Key Changes:

  • .github/workflows/blossom-ci.yml: 1 occurrence updated
  • .github/workflows/mvn-verify-check.yml: 8 occurrences updated across multiple jobs

Analysis:

  • All instances consistently updated from @v4 to @v5
  • No changes to action configurations (distribution, java-version remain the same)
  • Java versions used (8, 11, 17) are all supported by setup-java@v5
  • PR correctly includes [skip ci] tag to avoid unnecessary CI runs
  • Proactive maintenance ahead of Node 20 deprecation (March 2026)

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it's a straightforward dependency version bump for future-proofing
  • The change is a simple, well-documented version upgrade with no configuration changes. The v4 to v5 upgrade of actions/setup-java is backward compatible and only updates the underlying Node.js runtime from 20 to 24. All Java versions (8, 11, 17) remain supported, and the change is consistent across all 9 occurrences.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/blossom-ci.yml 5/5 Updated actions/setup-java from v4 to v5 for Node 24 compatibility
.github/workflows/mvn-verify-check.yml 5/5 Updated all 8 instances of actions/setup-java from v4 to v5 for Node 24 compatibility

Sequence Diagram

sequenceDiagram
    participant PR as Pull Request
    participant GHA as GitHub Actions Runner
    participant SJ4 as setup-java@v4 (Node 20)
    participant SJ5 as setup-java@v5 (Node 24)
    participant Java as Java Environment
    participant Build as Build/Test Jobs

    Note over PR,Build: Before: Using setup-java@v4
    PR->>GHA: Trigger workflow
    GHA->>SJ4: Call setup-java@v4
    Note over SJ4: Runs on Node 20
    SJ4->>Java: Setup Java 8/11/17
    Java->>Build: Execute Maven build/tests
    Build->>PR: Report results

    Note over PR,Build: After: Using setup-java@v5
    PR->>GHA: Trigger workflow
    GHA->>SJ5: Call setup-java@v5
    Note over SJ5: Runs on Node 24
    SJ5->>Java: Setup Java 8/11/17
    Java->>Build: Execute Maven build/tests
    Build->>PR: Report results

    Note over GHA,SJ5: Node 20 EOL: April 2026<br/>Node 24 ready: March 2026
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@pxLi
Copy link
Copy Markdown
Member Author

pxLi commented Dec 17, 2025

build

@pxLi pxLi merged commit c80330d into NVIDIA:main Dec 17, 2025
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to CI / CD or cleanly building

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants