Skip to content

Fix test cases: Iceberg datetime transforms#13856

Merged
liurenjie1024 merged 2 commits intoNVIDIA:release/25.12from
res-life:fix-test-cases-iceberg-datetime-transforms
Nov 24, 2025
Merged

Fix test cases: Iceberg datetime transforms#13856
liurenjie1024 merged 2 commits intoNVIDIA:release/25.12from
res-life:fix-test-cases-iceberg-datetime-transforms

Conversation

@res-life
Copy link
Copy Markdown
Collaborator

fixes #13852

Some cases were not updated in PR #13726.

Signed-off-by: Chong Gao res_life@163.com

Signed-off-by: Chong Gao <res_life@163.com>
@res-life
Copy link
Copy Markdown
Collaborator Author

build

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Nov 24, 2025

Greptile Overview

Greptile Summary

Updates Iceberg merge test cases to align with newly supported partition transforms introduced in PR #13726.

  • Adds year/month/day/hour partition transforms on date and timestamp columns to test_iceberg_merge (lines 160-166) to verify GPU execution now works correctly
  • Removes year/month/day/hour transforms from test_iceberg_merge_fallback_unsupported_partition_transform (lines 287-289) since these are now GPU-supported
  • Keeps only truly unsupported transforms in fallback test: identity partitioning, truncate(5, string_col), and bucket(8, string_col)
  • Fixes issue [BUG] Iceberg merge tests failing after Delta clustered table update support #13852 where 24 merge tests were failing because the tests expected GPU fallback but transforms were actually GPU-supported

Confidence Score: 5/5

  • This PR is safe to merge - it's a straightforward test update that mirrors changes already made to other test files
  • The changes are minimal, low-risk test parameterization updates that simply align the merge tests with the feature support added in PR Supports year/month/day/hour partition transforms for Iceberg #13726. The same pattern was already successfully applied to other Iceberg test files (append, delete, update, CTAS, RTAS, etc.). Column references are correct and the logic is sound.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
integration_tests/src/main/python/iceberg/iceberg_merge_test.py 5/5 Updates test parameterization to reflect newly supported year/month/day/hour partition transforms by adding them to positive tests and removing them from fallback tests

Sequence Diagram

sequenceDiagram
    participant PR13726 as PR #13726
    participant IcebergSupport as Iceberg GPU Support
    participant MergeTest as test_iceberg_merge
    participant FallbackTest as test_iceberg_merge_fallback_unsupported_partition_transform
    
    Note over PR13726,IcebergSupport: PR #13726 adds GPU support
    PR13726->>IcebergSupport: Implement year/month/day/hour transforms
    IcebergSupport-->>PR13726: Transforms now GPU-accelerated
    
    Note over MergeTest,FallbackTest: Tests need updating (missed in #13726)
    
    Note over PR13726,FallbackTest: Current PR #13856 fixes tests
    PR13726->>MergeTest: Add year/month/day/hour to test cases
    Note right of MergeTest: Now tests GPU execution<br/>with supported transforms
    
    PR13726->>FallbackTest: Remove year/month/day/hour from fallback tests
    Note right of FallbackTest: Only tests unsupported<br/>transforms (identity, truncate, bucket on string)
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@pxLi
Copy link
Copy Markdown
Member

pxLi commented Nov 24, 2025

Please help double confirm if this is required by 25.12 or 26.02? If 25.12 please rebase on release/25.12, thanks~

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@res-life res-life changed the base branch from main to release/25.12 November 24, 2025 04:04
@res-life
Copy link
Copy Markdown
Collaborator Author

target 25.12

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@res-life
Copy link
Copy Markdown
Collaborator Author

build

@liurenjie1024
Copy link
Copy Markdown
Collaborator

build

1 similar comment
@liurenjie1024
Copy link
Copy Markdown
Collaborator

build

@liurenjie1024 liurenjie1024 merged commit d5830f4 into NVIDIA:release/25.12 Nov 24, 2025
64 checks passed
@res-life res-life deleted the fix-test-cases-iceberg-datetime-transforms branch November 24, 2025 12:44
@sameerz sameerz added test Only impacts tests bug Something isn't working labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test Only impacts tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Iceberg merge tests failing after Delta clustered table update support

5 participants