Fix test cases: Iceberg datetime transforms#13856
Merged
liurenjie1024 merged 2 commits intoNVIDIA:release/25.12from Nov 24, 2025
Merged
Fix test cases: Iceberg datetime transforms#13856liurenjie1024 merged 2 commits intoNVIDIA:release/25.12from
liurenjie1024 merged 2 commits intoNVIDIA:release/25.12from
Conversation
Signed-off-by: Chong Gao <res_life@163.com>
Collaborator
Author
|
build |
Contributor
Greptile OverviewGreptile SummaryUpdates Iceberg merge test cases to align with newly supported partition transforms introduced in PR #13726.
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant PR13726 as PR #13726
participant IcebergSupport as Iceberg GPU Support
participant MergeTest as test_iceberg_merge
participant FallbackTest as test_iceberg_merge_fallback_unsupported_partition_transform
Note over PR13726,IcebergSupport: PR #13726 adds GPU support
PR13726->>IcebergSupport: Implement year/month/day/hour transforms
IcebergSupport-->>PR13726: Transforms now GPU-accelerated
Note over MergeTest,FallbackTest: Tests need updating (missed in #13726)
Note over PR13726,FallbackTest: Current PR #13856 fixes tests
PR13726->>MergeTest: Add year/month/day/hour to test cases
Note right of MergeTest: Now tests GPU execution<br/>with supported transforms
PR13726->>FallbackTest: Remove year/month/day/hour from fallback tests
Note right of FallbackTest: Only tests unsupported<br/>transforms (identity, truncate, bucket on string)
|
integration_tests/src/main/python/iceberg/iceberg_merge_test.py
Outdated
Show resolved
Hide resolved
Member
|
Please help double confirm if this is required by 25.12 or 26.02? If 25.12 please rebase on release/25.12, thanks~ |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Collaborator
Author
|
target 25.12 |
Collaborator
Author
|
build |
liurenjie1024
approved these changes
Nov 24, 2025
Collaborator
|
build |
1 similar comment
Collaborator
|
build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13852
Some cases were not updated in PR #13726.
Signed-off-by: Chong Gao res_life@163.com