Fix a GBK test failure on DB 143+[databricks]#13803
Fix a GBK test failure on DB 143+[databricks]#13803pxLi merged 2 commits intoNVIDIA:release/25.12from
Conversation
|
build |
Greptile Summary
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as "CSV Test"
participant Config as "Spark Config"
participant Scan as "GpuCSVScan"
participant Method as "supportedCharsets()"
Test->>Config: "Set spark.sql.legacy.javaCharsets=true"
Note over Config: Config updated at runtime
Test->>Scan: "Request CSV scan with GBK charset"
Scan->>Method: "Check if GBK supported"
Method->>Config: "Read current config value"
Config-->>Method: "Returns true (legacy enabled)"
Method-->>Scan: "Returns [UTF-8, US-ASCII, GBK]"
Scan-->>Test: "GBK is supported, scan proceeds on GPU"
|
There was a problem hiding this comment.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
|
still also please retarget this change to |
There was a problem hiding this comment.
74 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
|
|
|
reopen to keep the history, need a force push to eliminate the unexpected change involed by the base retargeting. |
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
d2022d7 to
0948856
Compare
There was a problem hiding this comment.
2 files reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
|
build |
close #13800
The root cause is missing the check for DB runtimes when specifying the legacy charset config for the CSV read, and should not cache the supported charset list, instead build it each time overriding the plan according to the current config.