Skip to content

[Backport] Enable Cython tests for cuda.bindings#359

Merged
leofang merged 12 commits into
NVIDIA:11.8.xfrom
leofang:cython_11_8
Jan 10, 2025
Merged

[Backport] Enable Cython tests for cuda.bindings#359
leofang merged 12 commits into
NVIDIA:11.8.xfrom
leofang:cython_11_8

Conversation

@leofang

@leofang leofang commented Jan 6, 2025

Copy link
Copy Markdown
Member

Cherry-picked from #323.

* enable Cython tests for cuda.bindings

* build Cython test modules

* Update gh-build-and-test.yml

* Install system gcc

* No sudo

* also set CUDA_HOME

* Try to find Python include

* nit: add a skip condition and comments

* simplify
@leofang leofang added P1 Medium priority - Should do CI/CD CI/CD infrastructure labels Jan 6, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 6, 2025
@leofang
leofang requested a review from vzhurba01 January 6, 2025 21:34
@leofang leofang self-assigned this Jan 6, 2025
@copy-pr-bot

copy-pr-bot Bot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang added the cuda.bindings Everything related to the cuda.bindings module label Jan 6, 2025
@leofang

leofang commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

Auto-backport of the new script has failed (#252 (comment)), let me hack it quickly in this PR.

@leofang

leofang commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

I am clueless...

+ CPLUS_INCLUDE_PATH=/__w/cuda-python/cuda-python/cuda_toolkit/include:
+ cythonize -3 -i test_ccuda.pyx test_ccudart.pyx test_interoperability_cython.pyx
Compiling /__w/cuda-python/cuda-python/cuda_bindings/tests_cython/test_ccuda.pyx because it changed.
/__w/cuda-python/cuda-python/cuda_bindings/tests_cython/test_ccuda.c:1242:10: fatal error: cuda.h: No such file or directory
 1242 | #include "cuda.h"
      |          ^~~~~~~~

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
Member Author

/ok to test

Comment thread cuda_bindings/tests_cython/test_ccuda.pyx
@leofang

leofang commented Jan 10, 2025

Copy link
Copy Markdown
Member Author

This is ready.

@leofang
leofang merged commit e56b97a into NVIDIA:11.8.x Jan 10, 2025
@leofang
leofang deleted the cython_11_8 branch January 10, 2025 19:59
rparolin added a commit to rparolin/cuda-python that referenced this pull request Jul 22, 2026
Record the residual risk from narrowing the cache-permission hardening
(glasswing NVIDIA#359/NVIDIA#375) per PR NVIDIA#2399 review: committed entry files stay 0o600
(contents owner-only via mkstemp+os.replace), tmp/ is owner-only to protect
in-flight writes, but root/entries inherit the umask so shared caches keep
working. In a group-writable shared cache a group member could replace a
cached kernel; tamper-proofing that path needs load-time integrity checks and
is out of scope here.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants