Skip to content

Hot-fix CCCL based TMA by simply disabling it for the moment #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seberg wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −23
Open

Hot-fix CCCL based TMA by simply disabling it for the moment #2777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions cuda_core/cuda/core/_cpp/tensor_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,15 @@
#include <algorithm>
#include <exception>

#if defined(__has_include)
// Older CTK releases do not ship <cuda/tma>. When it is unavailable we keep
// the CCCL helper compiled out and fall back to the direct driver path.
# if __has_include(<cuda/tma>)
# include <cuda/tma>
# define CUDA_CORE_HAS_CUDA_TMA 1
# else
# define CUDA_CORE_HAS_CUDA_TMA 0
# endif
# if __has_include("dlpack.h")
# include "dlpack.h"
# define CUDA_CORE_HAS_DLPACK_H 1
# elif __has_include(<dlpack/dlpack.h>)
# include <dlpack/dlpack.h>
# define CUDA_CORE_HAS_DLPACK_H 1
# else
# define CUDA_CORE_HAS_DLPACK_H 0
# endif
#else
# define CUDA_CORE_HAS_CUDA_TMA 0
# define CUDA_CORE_HAS_DLPACK_H 0
#endif

// TODO(seberg): As of 2026-09 CCCL does not fully avoid using nvrtc
// symbols. Until now, this code was never used (if it got compiled
// it lead to errors).
// When CCCL is fixed we should use CCCL as a submodule and redesign this
// code (possibly the datatype is also unimportant so we could a)
// See: https://github.com/NVIDIA/cccl/issues/11231
#define CUDA_CORE_HAS_CUDA_TMA 0


static inline void cuda_core_write_err(char* err, size_t cap, const char* msg) noexcept
{
Expand Down Expand Up @@ -68,7 +55,7 @@ int cuda_core_cccl_make_tma_descriptor_tiled(
char* err,
size_t err_cap) noexcept
{
#if !(CUDA_CORE_HAS_CUDA_TMA && CUDA_CORE_HAS_DLPACK_H)
#if !(CUDA_CORE_HAS_CUDA_TMA)
(void)out_tensor_map;
(void)data;
(void)device_type;
Expand Down
Loading