Skip to content

fix(ci): omit .pxd/.pxi so nightly coverage html can run - #2736

Merged
mdboom merged 2 commits into
NVIDIA:mainfrom
rluo8:ci/omit-pxd-cyruntime-pxi
Aug 31, 2026
Merged

fix(ci): omit .pxd/.pxi so nightly coverage html can run#2736
mdboom merged 2 commits into
NVIDIA:mainfrom
rluo8:ci/omit-pxd-cyruntime-pxi

Conversation

@rluo8

@rluo8 rluo8 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

closes #2723

Nightly CI: Coverage has failed since Aug 15 at coverage html: Cython.Coverage cannot build a FileReporter for .pxd / .pxi files (they are not standalone translation units). coverage combine itself succeeds; the old mega-step name made that hard to see.

[run] omit now uses */*.pxd and */*.pxi instead of listing three .pxd files by hand. A new file of either kind would otherwise break coverage html again.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Aug 31, 2026
@github-actions

This comment has been minimized.

@rluo8
rluo8 force-pushed the ci/omit-pxd-cyruntime-pxi branch from 23c883f to 5048fcc Compare August 31, 2026 08:18
Signed-off-by: Rui Luo <ruluo@nvidia.com>
@rluo8
rluo8 force-pushed the ci/omit-pxd-cyruntime-pxi branch from 5048fcc to 54a5745 Compare August 31, 2026 08:32
@rluo8 rluo8 changed the title Draft(ci): omit Cython .pxd and cyruntime.pxi from coverage reports fix(ci): omit .pxd/.pxi so nightly coverage html can run Aug 31, 2026
@rluo8 rluo8 self-assigned this Aug 31, 2026

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@mdboom
mdboom enabled auto-merge (squash) August 31, 2026 14:43
@mdboom mdboom added this to the cuda.bindings 13.4.0 & 12.9.8 milestone Aug 31, 2026
@mdboom mdboom added P0 High priority - Must do! bug Something isn't working labels Aug 31, 2026
@mdboom
mdboom merged commit 0244727 into NVIDIA:main Aug 31, 2026
214 of 218 checks passed
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@rluo8
rluo8 deleted the ci/omit-pxd-cyruntime-pxi branch September 1, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD CI/CD infrastructure P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Coverage deploy broken since Aug 15 — .coveragerc omit list enumerates Cython .pxd files by hand

2 participants