fix(cuda.pathfinder): discover Nsight GUI utilities under their current names - #2681
Draft
rootkiller6788 wants to merge 1 commit into
Draft
fix(cuda.pathfinder): discover Nsight GUI utilities under their current names#2681rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
…nt names find_nvidia_binary_utility() only supported the legacy CUDA-toolkit-bundled Nsight GUI names (nsight-sys/nsight-compute), which current standalone Nsight releases no longer ship. Add the modern GUI executable names nsys-ui and ncu-ui to the supported set, and resolve them on Windows from the standalone install registry (host-windows-*/ and host/windows-desktop-*/ directories, mirroring the existing nsys/ncu CLI discovery). The legacy names are kept for backward compatibility.
Contributor
github-actions
Bot
added
the
cuda.pathfinder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the gap reported in #2654:
find_nvidia_binary_utility()raisesUnsupportedBinaryErrorfor the current Nsight GUI executable namesnsys-ui/ncu-ui, and the legacy namesnsight-sys/nsight-computedo not resolve on current standalone Nsight installations.Changes:
supported_nvidia_binaries.py: registernsys-uiandncu-uiinSITE_PACKAGES_BINDIRS(same wheel dirs asnsys/ncu). Legacynsight-sys/nsight-computeentries are retained for backward compatibility.windows_nsight.py: addnsys_ui_candidate_paths()/ncu_ui_candidate_paths(), resolving the GUI launchers under the standalone install's host directories (host-windows-*for Nsight Systems,host/windows-desktop-*for Nsight Compute), keyed by native machine architecture like the existing CLI discovery.find_nvidia_binary_utility.py: routensys-ui/ncu-uito the new candidate paths on Windows (terminal, likensys/ncu); update the search-order docstring.Verification: full cuda_pathfinder test suite passes locally (1308 passed, 8 skipped); ruff check and format clean.