Skip to content

Use cuda.pathfinder to locate nvcc for object-code fixture #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 2 commits into from
Jul 1, 2026
+8 −3
Merged

Use cuda.pathfinder to locate nvcc for object-code fixture #2284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c0575d
Use pathfinder nvcc for object-code test fixture
rwgk Jul 1, 2026
78a0931
Merge branch 'main' into use-pathfinder-nvcc-for-object-code-test-fix…
rwgk Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cuda_core/tests/test_binaries/build_test_binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ if [[ "${OS:-}" == "Windows_NT" ]]; then
NVCC_EXTRA_FLAGS+=(-Xcompiler /Zc:preprocessor)
fi

nvcc -dc "${NVCC_EXTRA_FLAGS[@]}" -arch=all-major \
NVCC="${NVCC:-nvcc}"

"${NVCC}" -dc "${NVCC_EXTRA_FLAGS[@]}" -arch=all-major \
-o "${SCRIPTPATH}/saxpy.o" "${SCRIPTPATH}/saxpy.cu"

ls -lah "${SCRIPTPATH}/saxpy.o"
7 changes: 5 additions & 2 deletions cuda_core/tests/test_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,18 @@ def get_saxpy_object():
obj_path = binaries_dir / "saxpy.o"

if not obj_path.is_file():
if find_nvidia_binary_utility("nvcc") is None:
nvcc_path = find_nvidia_binary_utility("nvcc")
if nvcc_path is None:
pytest.skip(
f"saxpy.o not found at {obj_path} and nvcc is unavailable. "
"In CI this is downloaded from the build stage."
)
env = os.environ.copy()
env["NVCC"] = nvcc_path
Comment on lines +198 to +199

@leofang leofang Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

subprocess.run( # noqa: S603
["bash", str(binaries_dir / "build_test_binaries.sh")], # noqa: S607
check=True,
env=os.environ,
env=env,
)

return obj_path.read_bytes()
Expand Down
Loading