fix(e2e): detect gateway workload for Kubernetes health port-forward#2198
Closed
elezar wants to merge 1 commit into
Closed
fix(e2e): detect gateway workload for Kubernetes health port-forward#2198elezar wants to merge 1 commit into
elezar wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Label |
elezar
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
elezar
changed the title
elezar
force-pushed
the
fix/ha-e2e-health-portforward-workload-kind
branch
from
7de3f4e to
01180a4
Compare
elezar
commented
Jul 9, 2026
| image-tag: ${{ github.sha }} | ||
| runner: linux-arm64-cpu8 | ||
|
|
||
| kubernetes-e2e: |
Member
Author
There was a problem hiding this comment.
Should we duplicate these or rather factor out the k8s tests?
The health port-forward was hardcoded to sts/<name>, which breaks when the chart deploys a Deployment (workload.kind=deployment, used by the HA E2E). Add kube_workload_ref() to probe the cluster and return the correct resource reference at runtime. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
fix/ha-e2e-health-portforward-workload-kind
branch
from
01180a4 to
56cfba5
Compare
elezar
changed the title
elezar
force-pushed
the
fix/ha-e2e-health-portforward-workload-kind
branch
from
56cfba5 to
c61b114
Compare
Member
Author
|
Closing for now. HA behavior is not expected to pass on main until #1868 lands; we can reassess whether this port-forward adjustment is still needed once that work merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Kubernetes HA E2E deploys the gateway as a Deployment, but the test harness hardcoded the health port-forward to a StatefulSet. That caused the HA job to fail before the test suite could exercise the deployment.
This PR makes the minimal harness change required to select the deployed workload kind. The existing test:e2e-kubernetes label triggers the optional HA proof-of-life workflow.
HA gateway behavior is not expected to pass on current main. Full HA gateway rebalancing, peer routing, and supervisor relay handoff are being implemented in #1868. Until that PR merges, the HA suite is expected to expose those outstanding failures after this port-forward prerequisite succeeds.
Related Issue
Related to #2153, where the health port-forward failure was observed.
HA implementation: #1868.
Changes
Testing
Proof-of-life run for this minimal commit: https://github.com/NVIDIA/OpenShell/actions/runs/29091285118/job/86358988762
Checklist