Repository navigation
bug: mxc crate build is broken #3155
Description
User Story
As a developer working on OpenShell, I want the openshell-driver-mxc crate to compile successfully, so that I can build and test the full project on Windows.
Problem Statement
The openshell-driver-mxc crate fails to compile after commit 9b6d904 ("delegate sandbox authentication to drivers") introduced the authenticate_sandbox method on the ComputeDriver trait and added a supports_sandbox_authentication field to GetCapabilitiesResponse. The mxc driver was not updated to implement the new trait method or include the new field.
Impact / Why This Matters
Any developer attempting to build the full workspace or specifically the mxc crate hits a compile error, blocking all mxc-related development and testing on Windows. There is no workaround short of manually patching the code locally.
Acceptance Criteria
-
cargo check -p openshell-driver-mxccompiles without errors -
ComputeDriverServiceimplements theauthenticate_sandboxtrait method -
GetCapabilitiesResponseinitializer includes thesupports_sandbox_authenticationfield
Reproduction Steps
- Check out the
mainbranch at or after commit9b6d904e - Run
cargo check -p openshell-driver-mxc - Observe two compilation errors:
E0046: missingauthenticate_sandboxinComputeDriverimpl (grpc.rs:36)E0063: missing fieldsupports_sandbox_authenticationinGetCapabilitiesResponse(driver.rs:302)
Environment
- OpenShell: main branch @
9b6d904e - OS: Windows 11 Enterprise 10.0.26200
- Rust: 1.95.0 (59807616e 2026-04-14)
Logs
error[E0046]: not all trait items implemented, missing: `authenticate_sandbox`
--> crates\openshell-driver-mxc\src\grpc.rs:36:1
|
36 | impl ComputeDriver for ComputeDriverService {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `authenticate_sandbox` in implementation
error[E0063]: missing field `supports_sandbox_authentication` in initializer of `GetCapabilitiesResponse`
--> crates\openshell-driver-mxc\src\driver.rs:302:9
|
302 | GetCapabilitiesResponse {
| ^^^^^^^^^^^^^^^^^^^^^^^ missing `supports_sandbox_authentication`
Activity
jeffmaury commentedon Sep 3, 2026
Implementation Plan
Issue type:
fixComplexity: Low
Confidence: High — clear path, established pattern across Docker/Podman drivers
Summary
The MXC driver is missing the
authenticate_sandboxtrait method added in commit 9b6d904. Thesupports_sandbox_authenticationfield inGetCapabilitiesResponseis already present (set tofalse). Onlygrpc.rsneeds a one-method stub addition plus an import update, following the exact pattern used by Docker and Podman drivers.Scope
crates/openshell-driver-mxc/src/grpc.rs: AddAuthenticateSandboxRequest/AuthenticateSandboxResponseimports and implementauthenticate_sandboxreturningStatus::unimplementedImplementation Steps
AuthenticateSandboxRequest, AuthenticateSandboxResponseto the proto import block ingrpc.rsauthenticate_sandboxmethod stub toimpl ComputeDriver for ComputeDriverServicereturningErr(Status::unimplemented("mxc does not authenticate sandbox credentials"))Test Plan
cargo test -p openshell-driver-mxc). No new test needed — the method is a one-line unimplemented stub behind a capability gate, matching Docker/Podman which also don't test theirs.Risks & Open Questions
supports_sandbox_authentication: false.Documentation Impact
Revision 1 — initial plan
jeffmaury commentedon Sep 3, 2026
Implementation Complete
PR: #3158
What was built
Added the missing
authenticate_sandboxtrait method to the MXC driver, returningStatus::unimplementedto match the Docker/Podman pattern. Thesupports_sandbox_authenticationfield was already present indriver.rs.Tests
Docs updated
The issue will auto-close when the PR is merged.
fix(driver-mxc): implement authenticate_sandbox trait method (NVIDIA#…