[pcbeingused333]

Description

Closes #2808

Input paths that are already concrete files were passed through glob.glob a second time, so a file whose name contains glob metacharacters ([ ] * ?) was treated as a pattern:

• expand_service_file_patterns returned nothing for Invoice [2024].pdf, so the file was silently dropped in service mode.
• expand_input_file_patterns matched report[1].txt against report1.txt, so a directory containing both returned report1.txt twice and lost report[1].txt.

Both helpers now keep a path that is an existing file as a literal path and only glob otherwise, as suggested in the issue. User-supplied patterns are not escaped (see #1076), so docs/**/*.pdf and intentional bracket patterns behave as before.

New tests/test_literal_path_glob.py covers a bracketed file name in service and plain expansion, a directory with report1.txt plus report[1].txt, and a check that *.pdf still expands. The service and directory cases fail on main and pass with the change; black (line length 120) and flake8 from pre-commit are clean on the touched files.

This change was prepared with AI assistance (Claude Code).

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[greptile-apps]

Confidence Score: 2/5

[Medium impact] The change reaches file selection across several ingest routes.

The path fix appears sound, but the new test file must meet the repository's copyright-year and naming requirements before merging.

Findings

1.  Copyright year is outdated ▶
2.  Path variables have unclear names ▶

Fix with agent prompt

### Issue 1
nemo_retriever/tests/test_literal_path_glob.py:1
The new test file uses `2024-25` in its copyright header. The repository requires the current year for new Python files, so this header does not meet that requirement. Update it to include `2026`.

```suggestion
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES.
```

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 2
nemo_retriever/tests/test_literal_path_glob.py:13
Both new filename tests use `f` for the file path, here and on line 19. The repository requires descriptive variable names and allows single-letter names only for loop counters or lambda parameters. Rename both variables to `file_path` before merging to meet that requirement.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Existing files now bypass glob expansion in both helpers, preserving names with glob characters.

• Ingest keeps existing files with glob characters as literal paths.

pcbeingused333 explicitly describes existing-file precedence over a matching glob as intentional in the PR description.

_{Reviews (1) · Last reviewed commit: "fix(ingest): treat existing files with g..." · Reviewed by Greptile}

[greptile-apps]

Copyright year is outdated

The new test file uses 2024-25 in its copyright header. The repository requires the current year for new Python files, so this header does not meet that requirement. Update it to include 2026.

Suggested change

	# SPDX-FileCopyrightText: Copyright (c) 2024-25, NVIDIA CORPORATION & AFFILIATES.
	# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES.

Rule Used: Python files added in this PR must include the SPDX license header at the top: # SPDX-FileCopyrightText: Copyright (c) <year>, NVIDIA CORPORATION & AFFILIATES. # All rights reserved. # SPDX-License-Identifier: Apache-2.0 Use the current year for ne... (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: nemo_retriever/tests/test_literal_path_glob.py
Line: 1

Comment:
**Copyright year is outdated**

The new test file uses `2024-25` in its copyright header. The repository requires the current year for new Python files, so this header does not meet that requirement. Update it to include `2026`.

```suggestion
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES.
```

**Rule Used:** Python files added in this PR must include the SPDX license header at the top:  # SPDX-FileCopyrightText: Copyright (c) <year>, NVIDIA CORPORATION & AFFILIATES. # All rights reserved. # SPDX-License-Identifier: Apache-2.0  Use the current year for ne... ([source](https://github.com/nvidia/nemo-retriever/blob/cc1db1b2ba66615d71c20c615a81f7b01211c6b0/.greptile/config.json))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Path variables have unclear names

Both new filename tests use f for the file path, here and on line 19. The repository requires descriptive variable names and allows single-letter names only for loop counters or lambda parameters. Rename both variables to file_path before merging to meet that requirement.

Rule Used: Variables, functions, classes, and modules must have descriptive names. Single-letter variables are acceptable only as loop counters or lambda parameters. (source)

Prompt To Fix With AI

This is a comment left during a code review.
Path: nemo_retriever/tests/test_literal_path_glob.py
Line: 13

Comment:
**Path variables have unclear names**

Both new filename tests use `f` for the file path, here and on line 19. The repository requires descriptive variable names and allows single-letter names only for loop counters or lambda parameters. Rename both variables to `file_path` before merging to meet that requirement.

**Rule Used:** Variables, functions, classes, and modules must have descriptive names. Single-letter variables are acceptable only as loop counters or lambda parameters. ([source](https://github.com/nvidia/nemo-retriever/blob/cc1db1b2ba66615d71c20c615a81f7b01211c6b0/.greptile/config.json))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!