Move Mistral Medium recipe under canonical base model - #2150
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR adds a Mistral Medium 3.5 PTQ recipe at the canonical Hugging Face model path. It updates the changelog, checkpoint-mirror documentation, and built-in recipe coverage to use the new path. ChangesMistral Medium PTQ recipe
Estimated code review effort: 2 (Simple) | ~15 minutes Mergeability Score: ⚪ Minimal · up to This change moves the recipe to the canonical model path and updates its references and documentation; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4ff9cd7 to
b135cd1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2150 +/- ##
==========================================
- Coverage 78.66% 78.14% -0.53%
==========================================
Files 522 522
Lines 60420 60420
==========================================
- Hits 47532 47214 -318
- Misses 12888 13206 +318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| The `huggingface/models/` tier reproduces a **single published (or planned) | ||
| checkpoint's** quant config verbatim: | ||
|
|
||
| - **`Mistral-Medium-3.5-128B-NVFP4/ptq/nvfp4-max-calib`** mirrors |
There was a problem hiding this comment.
if this is a quant config for a checkpoint, it could go under models/mistralai/Mistral-Medium-3.5-128B so that users can easily find it via the HF model name. what do you think?
There was a problem hiding this comment.
Sure, makes sense. We can use the canonical HF base model name.
NV's quantized: https://huggingface.co/nvidia/Mistral-Medium-3.5-128B-NVFP4
-> Vendor's base model: https://huggingface.co/mistralai/Mistral-Medium-3.5-128B
-> modelopt_recipes/huggingface/models/mistralai/Mistral-Medium-3.5-128B/ptq/
There was a problem hiding this comment.
[agent comment]
Updated in e014704: the recipe now lives under modelopt_recipes/huggingface/models/mistralai/Mistral-Medium-3.5-128B/ptq/; the catalog, changelog, and loader smoke test use the same path.
b135cd1 to
e014704
Compare
e014704 to
14a7bfe
Compare
Signed-off-by: Chad Voegele <cvoegele@nvidia.com>
14a7bfe to
9a4d417
Compare
|
/ok to test 9a4d417 — Chad's Agent |
|
/ok to test 9a4d417 |
What does this PR do?
Type of change: Bug fix
Moves the Mistral Medium 3.5 checkpoint-mirror PTQ recipe under the canonical Hugging Face base model,
mistralai/Mistral-Medium-3.5-128B. Updates the recipe catalog, loader smoke-test path, and changelog.Usage
python examples/hf_ptq/hf_ptq.py \ --model mistralai/Mistral-Medium-3.5-128B \ --recipe huggingface/models/mistralai/Mistral-Medium-3.5-128B/ptq/nvfp4-max-calibTesting
uvx --from pre-commit pre-commit run --files CHANGELOG.rst modelopt_recipes/huggingface/models/mistralai/Mistral-Medium-3.5-128B/ptq/nvfp4-max-calib.yaml modelopt_recipes/ptq.md tests/unit/recipe/test_loader.pyBefore your PR is "Ready for review"
CONTRIBUTING.md: N/AAdditional Information
The recipe targets the vendor's canonical base checkpoint,
mistralai/Mistral-Medium-3.5-128B, and reproduces NVIDIA'sMistral-Medium-3.5-128B-NVFP4quantization map.Summary by CodeRabbit
New Features
Documentation
Breaking Changes