Skip to content

Pin NCode Review v1.0.0 and record outcomes in a job of its own - #21

Merged
polewskm merged 3 commits into
mainfrom
code-review-v1
Nov 1, 2026
Merged

polewskm merged 3 commits into
mainfrom
code-review-v1

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Bumps NCode Review to v1.0.0 (d14405f82771819586a5ccbff636929dc894b780), the first full release, which freezes the caller–engine interface. This repository's caller still pins v0.3.1.

  • Adds closed to the pull_request_target types. When a pull request closes, a separate outcomes job records each finding's outcome (fixed, dismissed, acknowledged or ignored) in the summary comment, by rules alone. That job runs outside the code-review environment, without id-token: write, the Bedrock key or a checkout. v0.3.1 treated a closed pull request like an opened one, so closed waited for this pin.
  • The review job gets v0.4.0's and v1.0.0's caller changes: /review explain and /review teach each run in a concurrency group of their own, and issues: read lets the bot link a finding to an open issue that already tracks it.
  • v1.0.0 runs verification by default and has every engine change since v0.3.1 (changelog).

The file is now the caller in NCode Review's README and in NCodeGroup/code-review's own workflow.

Refs NCodeGroup/code-review#97

@polewskm
polewskm deployed to code-review November 1, 2026 07:36 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 22da372: 2 new findings on the changed lines.

Comment thread .github/workflows/code-review.yml Resolved
Comment thread .github/workflows/code-review.yml Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — No findings.

5 reviewers run — 0 findings (run details)

Reviewer Model Findings Top
conventions sonnet-5-5 0 🟢
correctness sonnet-5-5 0 🟢
hygiene haiku-5-5 0 🟢
rule-check sonnet-5-5 0 🟢
security sonnet-5-5 0 🟢

Skipped: api-compat, architecture, completeness, data-model, infrastructure, intent, performance, tests

Trial: findings are posted as review threads and in the check run. $0.17 on Amazon Bedrock, 31s, at acc3c47. (how to interact)

📋 Outcomes

Merged at acc3c47: 3 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 at 22da372 rule-check 🟠 Should fix 👎 dismissed
F2 at 22da372 hygiene 🟡 Nit ✅ fixed
F1 at 9c56218 rule-check 🟡 Nit ✅ fixed
F2 at 9c56218 hygiene 🟡 Nit ✅ fixed

@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 9c56218: 2 new findings on the changed lines.

Comment thread .github/workflows/code-review.yml Resolved
Comment thread .github/workflows/code-review.yml Resolved
@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@polewskm
polewskm marked this pull request as ready for review November 1, 2026 09:13
@polewskm
polewskm deployed to code-review November 1, 2026 09:13 — with GitHub Actions Active
@polewskm
polewskm merged commit 318d94f into main Nov 1, 2026
10 checks passed
@polewskm
polewskm deleted the code-review-v1 branch November 1, 2026 09:13

This branch was successfully deployed

1 active deployment
code-review — acc3c478 Deployed Nov 1, 2026 by polewskm via review #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant