Repository navigation
Pin NCode Review v1.0.0 and record outcomes in a job of its own - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 22da372: 2 new findings on the changed lines.
🤖 Review completeVerdict: ✅ Approve — No findings. 5 reviewers run — 0 findings (run details)
Skipped: api-compat, architecture, completeness, data-model, infrastructure, intent, performance, tests Trial: findings are posted as review threads and in the check run. $0.17 on Amazon Bedrock, 31s, at acc3c47. (how to interact) 📋 OutcomesMerged at acc3c47: 3 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
…comes job needs no environment
Contributor
Author
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at 9c56218: 2 new findings on the changed lines.
Contributor
Author
|
/review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps NCode Review to v1.0.0 (
d14405f82771819586a5ccbff636929dc894b780), the first full release, which freezes the caller–engine interface. This repository's caller still pins v0.3.1.closedto thepull_request_targettypes. When a pull request closes, a separateoutcomesjob records each finding's outcome (fixed, dismissed, acknowledged or ignored) in the summary comment, by rules alone. That job runs outside thecode-reviewenvironment, withoutid-token: write, the Bedrock key or a checkout. v0.3.1 treated a closed pull request like an opened one, soclosedwaited for this pin.reviewjob gets v0.4.0's and v1.0.0's caller changes:/review explainand/review teacheach run in a concurrency group of their own, andissues: readlets the bot link a finding to an open issue that already tracks it.The file is now the caller in NCode Review's README and in NCodeGroup/code-review's own workflow.
Refs NCodeGroup/code-review#97