Repository navigation
Read the SQL declarations without their comments - #150
Merged
estebanzimanyi merged 1 commit intoSep 30, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
estebanzimanyi
force-pushed
the
catalog/sql-without-comments
branch
from
September 30, 2026 13:05
f1587a9 to
ca4ef2f
Compare
The SQL signatures are read from the CREATE FUNCTION statements with every -- and /* */ comment blanked first, newlines kept and string literals stepped over, as parser/temporaltypes.py reads C. A statement commented out is no declaration: the extension does not create it, so no binding may register it. A commented line inside a declaration is no part of it: asMVTGeom(tgeompoint, ...) keeps an older -- RETURNS tgeompoint above its RETURNS geom_times, which left the statement without a return type. Measured. Over MobilityDB a362004728 the catalog drops 6 signatures the extension does not create, each commented out in its .in.sql: stops(tgeometry, float, interval), stops(tgeography, float, interval), stops(tjsonb, interval), tsample(trgeometry, interval, timestamptz), bearing(tgeogpoint, tgeogpoint) and asMVTGeom(tgeometry, ...), and asMVTGeom(tgeompoint, ...) returns geom_times, so tpoint_as_mvtgeom states its sqlReturnType. The catalog is otherwise identical. Witness. tests/test_sql_comments.py blanks line and nested block comments, keeps a comment opener inside a literal, registers nothing for a declaration commented out, and reads the return type and the arguments of a declaration carrying commented lines.
estebanzimanyi
force-pushed
the
catalog/sql-without-comments
branch
from
September 30, 2026 13:14
ca4ef2f to
3fe93a9
Compare
estebanzimanyi
pushed a commit
that referenced
this pull request
Oct 5, 2026
…ction share A wrapper and the MEOS function a signature names can meet at a shared kernel rather than one calling the other: Distance_value_set, the wrapper of setDistance(integer, intset), reads the value first and calls distance_set_value(s, value), and distance_set_int(s, i) calls the same kernel over s and its integer converted. parser/boundargs.py reads the order of the SQL arguments through that kernel where the wrapper does not call the function: a parameter of the function carries the SQL argument the wrapper passes at the kernel position where the function passes that parameter, the kernel being the first callee of the function's body the wrapper calls with as many arguments. The bodies come from the documented MEOS definitions, read with the pattern the parameter lists are read with. Witness: over MobilityDB master 4c4457d2ec the catalog states no order for setDistance(integer, intset), whose wrapper reads the value before the set while distance_set_int takes the set first, so the typed Spark and Flink surfaces refuse it as "arg:integer/Set *" while they register setDistance(intset, integer); so for the value-first forms of setDistance, spanDistance and spansetDistance over the five base types, and the number-first forms of nearestApproachDistance over tint, tbigint and tfloat and of tDistance over tint and tfloat. Measured over MobilityDB master 4c4457d2ec and the installed headers of a libmeos built from it: 104 orders other than the C order, from 84, the 20 added being those signatures, each stating the value or the number first; the catalog differs from master's in these fields alone. The typed surfaces JMEOS main generates from it register 7433 overloads, from 7415, the 18 added passing the value first; the integer forms of nearestApproachDistance follow the float result of JMEOS #150. The suite passes, 25 tests skipped as on master, tests/test_boundargs.py stating the kernel order, the kernel in the C order and the function without its body on synthetic bodies, and nearestApproachDistance(float, tfloat) over the generated catalog. Why: where the wrapper and the function call one kernel, the kernel call is where each pairs its arguments, so the catalog composes the two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL signatures are read from the CREATE FUNCTION statements with every
-- and /* */ comment blanked first, newlines kept and string literals stepped
over, as parser/temporaltypes.py reads C. A statement commented out is no
declaration: the extension does not create it, so no binding may register
it. A commented line inside a declaration is no part of it:
asMVTGeom(tgeompoint, ...) keeps an older -- RETURNS tgeompoint above its
RETURNS geom_times, which left the statement without a return type.
Measured. Over MobilityDB a362004728 the catalog drops 6 signatures the
extension does not create, each commented out in its .in.sql:
stops(tgeometry, float, interval), stops(tgeography, float, interval),
stops(tjsonb, interval), tsample(trgeometry, interval, timestamptz),
bearing(tgeogpoint, tgeogpoint) and asMVTGeom(tgeometry, ...), and
asMVTGeom(tgeompoint, ...) returns geom_times, so tpoint_as_mvtgeom states
its sqlReturnType. The catalog is otherwise identical.
Witness. tests/test_sql_comments.py blanks line and nested block comments,
keeps a comment opener inside a literal, registers nothing for a declaration
commented out, and reads the return type and the arguments of a declaration
carrying commented lines.