Repository navigation
fix: store stream usage as a dict so results can be saved - #70
Open
Iamsohungrynow wants to merge 1 commit into
Open
Iamsohungrynow wants to merge 1 commit into
Iamsohungrynow wants to merge 1 commit into
Conversation
since MiniMax-AI#56 the stream path keeps event.usage as a CompletionUsage object, so validate_file's json.dumps raises TypeError on any --stream run where the provider sends usage, leaving results.jsonl empty and no summary. model_dump() it like the non-stream path does
Author
|
hi @wumingxiami, could you take a look at this and #71 when you have time? both still apply cleanly after #75 and #76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since #56 stream mode keeps
event.usageas aCompletionUsageobject, sovalidate_filecrashes onjson.dumpsand leaves results.jsonl empty. it'smodel_dump()ed now like the non-stream path, and the stream test checks the response serializesNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.