refactor(wallet-cli): Replace { wallet, store } with { wallet, dispose }

[sirtimid]

Summary

• createWallet in daemon/wallet-factory now returns { wallet, dispose } instead of { wallet, store }. dispose is the single owner of teardown — it runs await wallet.destroy() then store.close(), with per-step failures forwarded to the supplied logger (or console.error if none).
• The two daemon cleanup ladders in daemon-entry.ts (startup-failure catch block + SIGTERM/SIGINT shutdown closure) now both call dispose instead of inlining the order, so a future third call site or extra teardown step can't drift.
• The disposer is idempotent (concurrent and sequential calls coalesce onto a single teardown promise), closes the store even when wallet.destroy() rejects, and survives a throwing user-supplied logger.
• The pre-resolution catch block inside createWallet was tightened to route through the same reporter, so a store.close() throw during first-run cleanup can no longer mask the original failure (e.g. bad SRP).

Closes #8779. Builds on #8446 (the deferred refactor was tracked there).

Test plan

• yarn workspace @metamask/wallet-cli run test — 250 passing, 100% statements/branches/funcs/lines on wallet-factory.ts and daemon-entry.ts.
• yarn workspace @metamask/wallet-cli run build — clean.
• yarn eslint packages/wallet-cli/src — clean.
• yarn workspace @metamask/wallet-cli run changelog:validate — clean (no entry; the package is unreleased and this is internal).
• New tests cover: destroy-before-close ordering, concurrent + sequential coalescence, store-closes-even-when-destroy-rejects, log routing for each step, console.error fallback when no logger supplied, console.error fallback when the supplied logger throws, and store.close throwing during first-run cleanup not masking the original error.

🤖 Generated with Claude Code

[sirtimid]

Superseded by #9226, which lands createWallet + daemon-entry directly on main and folds in this { wallet, dispose } refactor (idempotent, resilient teardown). It additionally adds the unsubscribe step that this branch's older rekm/wallet-cli base didn't need (on main, post-#9067 subscribeToChanges returns an unsubscribe fn rather than relying on a Wallet:destroyed event). #8779 is closed by #9226.