fix(types): widen type hints for agent init#1278
Conversation
Review Summary by QodoWiden type hints for agent initialization parameters
WalkthroughsDescription• Widen type hints for agent initialization parameters • Add support for string and dict configuration formats • Improve flexibility in accepting multiple input types • Align with actual parameter handling capabilities Diagramflowchart LR
A["Agent Init Parameters"] -->|"Add str, Dict support"| B["context, autonomy, output"]
A -->|"Add str, Dict support"| C["execution, templates, caching"]
A -->|"Add str, Dict support"| D["hooks, skills, approval, learn"]
B --> E["Flexible Type Hints"]
C --> E
D --> E
File Changes1. src/praisonai-agents/praisonaiagents/agent/agent.py
|
Code Review by Qodo
1. Autonomy preset strings ignored
|
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request widens the type hints for several parameters in the Agent constructor, including context, autonomy, approval, and learn, to support strings and dictionaries. However, the review identifies multiple instances where the underlying implementation has not been updated to handle these new types, which could lead to runtime errors or features being silently disabled.
| caching: Optional[Union[bool, str, Dict[str, Any], 'CachingConfig']] = None, | ||
| hooks: Optional[Union[List[Any], Dict[str, Any], 'HooksConfig']] = None, | ||
| skills: Optional[Union[List[str], str, Dict[str, Any], 'SkillsConfig']] = None, | ||
| approval: Optional[Union[bool, str, Dict[str, Any], 'ApprovalConfig', 'ApprovalProtocol']] = None, |
There was a problem hiding this comment.
The widened type hint for approval includes Dict[str, Any], but the implementation (lines 1624-1659) does not convert a dictionary to an ApprovalConfig or backend instance. Instead, it assigns the dictionary directly to self._approval_backend in the else block at line 1654. This will cause runtime errors when the agent attempts to call backend methods on a dictionary object.
| web: Optional[Union[bool, str, 'WebConfig']] = None, | ||
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, | ||
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, |
There was a problem hiding this comment.
The widened type hint for context includes str and Dict[str, Any], but the implementation in the context_manager property (lines 1877-1966) does not currently handle these types. If a string or dictionary is passed, the context manager will be silently disabled (set to None).
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, | ||
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, str, Dict[str, Any], 'AutonomyConfig']] = None, |
There was a problem hiding this comment.
The widened type hint for autonomy includes str, but the _init_autonomy method (lines 2138-2188) does not handle string inputs. Passing a string (e.g., a preset name) will result in autonomy being disabled because it falls into the else block at line 2177.
| approval: Optional[Union[bool, str, Dict[str, Any], 'ApprovalConfig', 'ApprovalProtocol']] = None, | ||
| tool_timeout: Optional[int] = None, # P8/G11: Timeout in seconds for each tool call | ||
| learn: Optional[Union[bool, Dict[str, Any], 'LearnConfig']] = None, # Continuous learning (peer to memory) | ||
| learn: Optional[Union[bool, str, Dict[str, Any], 'LearnConfig']] = None, # Continuous learning (peer to memory) |
There was a problem hiding this comment.
The widened type hint for learn includes str, but the initialization logic (lines 1067-1080) does not explicitly handle string values. This may lead to unexpected behavior or truthiness issues when the value is passed through to the memory system at line 1096.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/praisonai-agents/praisonaiagents/agent/agent.py`:
- Around line 491-492: Update the type hints for the Agent parameters to match
only the runtime-supported shapes: remove str (and dict for context) from the
annotated unions so `context` is Optional[Union[bool, Dict[str, Any],
'ContextConfig', 'ContextManager']]` becomes Optional[Union[bool,
'ContextConfig', 'ContextManager']]` (or Optional[Union[bool, 'ContextManager',
'ContextConfig']] as appropriate) and `autonomy` drops `str` to be
Optional[Union[bool, 'AutonomyConfig']]; locate the parameter declarations in
agent.py (the `context` and `autonomy` parameters), and also scan
`_init_autonomy` and `context_manager` code paths to ensure annotations match
implemented branches and update any docstrings/comments to reflect the
false=True=Config contract.
- Line 500: The public type for the approval parameter includes Dict[str, Any]
but the approval handling logic only handles bool, True, ApprovalConfig and
ApprovalProtocol and sends any other value to the generic else branch; add a
dedicated branch that detects when approval is a dict and coerces it into an
ApprovalConfig (e.g., ApprovalConfig(**approval) or
ApprovalConfig.from_dict(approval)) before the existing protocol/object handling
so dictionaries follow the same config-path as ApprovalConfig; update the code
that currently checks approval (the approval processing block in the Agent
constructor/initializer where approval is normalized) to convert dict ->
ApprovalConfig and then continue with the existing branches for ApprovalConfig
and ApprovalProtocol.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 37222d53-da7d-41fe-8989-3fc9f207ac5e
📒 Files selected for processing (1)
src/praisonai-agents/praisonaiagents/agent/agent.py
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, str, Dict[str, Any], 'AutonomyConfig']] = None, |
There was a problem hiding this comment.
context/autonomy type hints now advertise unsupported runtime inputs.
Line 491 and Line 492 add str (and dict for context), but current runtime paths don’t normalize these forms (context_manager has no str/dict branch; _init_autonomy treats unsupported types as disabled). This creates a silent contract mismatch.
💡 Proposed fix (narrow hints to implemented behavior)
- context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None,
- autonomy: Optional[Union[bool, str, Dict[str, Any], 'AutonomyConfig']] = None,
+ context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None,
+ autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None,As per coding guidelines: src/praisonai-agents/praisonaiagents/agent/*.py: “Consolidate Agent parameters into Config objects following the pattern: False=disabled, True=defaults, Config=custom.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/praisonai-agents/praisonaiagents/agent/agent.py` around lines 491 - 492,
Update the type hints for the Agent parameters to match only the
runtime-supported shapes: remove str (and dict for context) from the annotated
unions so `context` is Optional[Union[bool, Dict[str, Any], 'ContextConfig',
'ContextManager']]` becomes Optional[Union[bool, 'ContextConfig',
'ContextManager']]` (or Optional[Union[bool, 'ContextManager', 'ContextConfig']]
as appropriate) and `autonomy` drops `str` to be Optional[Union[bool,
'AutonomyConfig']]; locate the parameter declarations in agent.py (the `context`
and `autonomy` parameters), and also scan `_init_autonomy` and `context_manager`
code paths to ensure annotations match implemented branches and update any
docstrings/comments to reflect the false=True=Config contract.
There was a problem hiding this comment.
Pull request overview
This PR cherry-picks a commit that broadens Agent.__init__ configuration type hints to accept additional shorthand forms (e.g., str/dict/bool) for several consolidated feature parameters, aiming to make agent initialization more flexible and consistent with config-driven usage.
Changes:
- Widened type hints for
context,autonomy,output,execution,templates,caching,hooks,skills,approval, andlearn. - Expanded several parameters to allow
Dict[str, Any](and in some casesstr/bool) in the constructor signature.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, | ||
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, str, Dict[str, Any], 'AutonomyConfig']] = None, |
There was a problem hiding this comment.
The type hint now allows autonomy to be a str, but _init_autonomy() currently only handles True, dict, or AutonomyConfig and will silently disable autonomy for string inputs (e.g. documented autonomy="full_auto"). Either add explicit string handling (map presets like "full_auto"/"auto_edit"/"suggest" to an AutonomyConfig(level=...)) or remove str from the public signature to match behavior.
| autonomy: Optional[Union[bool, str, Dict[str, Any], 'AutonomyConfig']] = None, | |
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, |
| web: Optional[Union[bool, str, 'WebConfig']] = None, | ||
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, | ||
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, |
There was a problem hiding this comment.
The signature now claims context supports str/dict, but context_manager initialization only recognizes True, ManagerConfig, ContextConfig, or a ContextManager-like object; str/dict fall through to the “unknown type, disable” branch. Either implement parsing for dict/str (e.g. dict -> ManagerConfig(**...) / ContextConfig.from_dict(...), and define what string means), or narrow the type hint so callers don’t get a false affordance.
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, | |
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, |
| approval: Optional[Union[bool, str, 'ApprovalConfig', 'ApprovalProtocol']] = None, | ||
| output: Optional[Union[bool, str, Dict[str, Any], 'OutputConfig']] = None, | ||
| execution: Optional[Union[bool, str, Dict[str, Any], 'ExecutionConfig']] = None, | ||
| templates: Optional[Union[str, Dict[str, Any], 'TemplateConfig']] = None, |
There was a problem hiding this comment.
templates is now typed as accepting str, but the resolver path doesn’t interpret non-path-like strings for TemplateConfig (it will generally return an empty TemplateConfig() which has no effect). If the intent is to accept a template preset name or file path, add explicit handling for those string forms; otherwise, remove str from the type hint to avoid misleading API docs/type-checkers.
| templates: Optional[Union[str, Dict[str, Any], 'TemplateConfig']] = None, | |
| templates: Optional[Union[Dict[str, Any], 'TemplateConfig']] = None, |
| caching: Optional[Union[bool, str, Dict[str, Any], 'CachingConfig']] = None, | ||
| hooks: Optional[Union[List[Any], Dict[str, Any], 'HooksConfig']] = None, | ||
| skills: Optional[Union[List[str], str, Dict[str, Any], 'SkillsConfig']] = None, | ||
| approval: Optional[Union[bool, str, Dict[str, Any], 'ApprovalConfig', 'ApprovalProtocol']] = None, |
There was a problem hiding this comment.
approval is now typed to accept a Dict[str, Any], but the approval initialization logic only handles str presets, bool, or ApprovalConfig; a dict will fall into the “plain backend object” branch and likely fail later when treated as an ApprovalProtocol. Either support dict form explicitly (e.g. approval={"backend": ..., "all_tools": ..., "timeout": ...} -> ApprovalConfig(**...)) or drop Dict[...] from the type hint.
| approval: Optional[Union[bool, str, Dict[str, Any], 'ApprovalConfig', 'ApprovalProtocol']] = None, | |
| approval: Optional[Union[bool, str, 'ApprovalConfig', 'ApprovalProtocol']] = None, |
| approval: Optional[Union[bool, str, Dict[str, Any], 'ApprovalConfig', 'ApprovalProtocol']] = None, | ||
| tool_timeout: Optional[int] = None, # P8/G11: Timeout in seconds for each tool call | ||
| learn: Optional[Union[bool, Dict[str, Any], 'LearnConfig']] = None, # Continuous learning (peer to memory) | ||
| learn: Optional[Union[bool, str, Dict[str, Any], 'LearnConfig']] = None, # Continuous learning (peer to memory) |
There was a problem hiding this comment.
learn is now typed to accept a str, but __init__ currently passes unknown types through into memory["learn"], and Memory.learn only enables learning for bool, dict, or LearnConfig (other types return None). If you want a string shorthand (e.g. learn="agentic"), convert it into LearnConfig(mode=...); otherwise, remove str from the type hint to match runtime behavior.
| learn: Optional[Union[bool, str, Dict[str, Any], 'LearnConfig']] = None, # Continuous learning (peer to memory) | |
| learn: Optional[Union[bool, Dict[str, Any], 'LearnConfig']] = None, # Continuous learning (peer to memory) |
| output: Optional[Union[bool, str, Dict[str, Any], 'OutputConfig']] = None, | ||
| execution: Optional[Union[bool, str, Dict[str, Any], 'ExecutionConfig']] = None, |
There was a problem hiding this comment.
output/execution type hints were widened to include bool and Dict[str, Any], but the Args: docstring section still only documents the str preset and *Config forms. Please update the docstring to reflect the supported bool/dict shorthands (and their semantics: True -> defaults, False -> disabled, dict -> config overrides).
| output: Optional[Union[bool, str, Dict[str, Any], 'OutputConfig']] = None, | |
| execution: Optional[Union[bool, str, Dict[str, Any], 'ExecutionConfig']] = None, | |
| output: Optional[Union[bool, str, Dict[str, Any], 'OutputConfig']] = None, # True=default OutputConfig, False=disabled, dict=config overrides | |
| execution: Optional[Union[bool, str, Dict[str, Any], 'ExecutionConfig']] = None, # True=default ExecutionConfig, False=disabled, dict=config overrides |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, | ||
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, str, Dict[str, Any], 'AutonomyConfig']] = None, |
There was a problem hiding this comment.
1. Autonomy preset strings ignored 🐞 Bug ≡ Correctness
Agent.__init__ now advertises autonomy can be a string, but _init_autonomy does not handle str values and will disable autonomy instead of applying presets like "full_auto". This breaks the public contract implied by AUTONOMY_PRESETS and AutonomyConfig docs.
Agent Prompt
### Issue description
`Agent.__init__` now type-hints `autonomy` as accepting `str`, but the runtime path (`_init_autonomy`) does not handle strings and silently disables autonomy when a string is passed (e.g. `"full_auto"`).
### Issue Context
The repo already defines `AUTONOMY_PRESETS` containing `"full_auto"`, and `AutonomyConfig` docs show `Agent(autonomy="full_auto")`, so string presets appear to be a supported user-facing API.
### Fix Focus Areas
- src/praisonai-agents/praisonaiagents/agent/agent.py[1314-1320]
- src/praisonai-agents/praisonaiagents/agent/agent.py[2137-2188]
- src/praisonai-agents/praisonaiagents/config/presets.py[298-307]
- src/praisonai-agents/praisonaiagents/config/param_resolver.py[600-610]
### Suggested fix
Either:
1) Implement `str` handling by resolving presets before `_init_autonomy` (e.g., use `AUTONOMY_PRESETS` / `resolve_autonomy()` to produce an `AutonomyConfig`), or
2) Revert the type hint to remove `str` if string presets are not intended to be supported.
Add/adjust a unit test for `Agent(autonomy="full_auto")` to assert `agent.autonomy_enabled is True` and that the configured level/mode matches the preset.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| web: Optional[Union[bool, str, 'WebConfig']] = None, | ||
| context: Optional[Union[bool, 'ContextConfig', 'ContextManager']] = None, | ||
| autonomy: Optional[Union[bool, Dict[str, Any], 'AutonomyConfig']] = None, | ||
| context: Optional[Union[bool, str, Dict[str, Any], 'ContextConfig', 'ContextManager']] = None, |
There was a problem hiding this comment.
2. Context presets/dicts ignored 🐞 Bug ≡ Correctness
Agent.__init__ now advertises context can be a str or dict, but context_manager lazy-init only supports bool, ManagerConfig/ContextConfig, or a ContextManager instance; str/dict values fall into the unknown-type branch and disable context. This causes silent misconfiguration where context management never activates.
Agent Prompt
### Issue description
`Agent.__init__` now type-hints `context` as accepting `str` and `dict`, but the runtime context initialization only recognizes `True/False`, `ManagerConfig`/`ContextConfig`, or `ContextManager`. Passing a preset string or a dict results in context being silently disabled.
### Issue Context
The repo already provides `CONTEXT_PRESETS` and a canonical `resolve_context()` helper (supports string presets and dict-to-config conversion), but Agent stores the raw value and never resolves it.
### Fix Focus Areas
- src/praisonai-agents/praisonaiagents/agent/agent.py[1753-1761]
- src/praisonai-agents/praisonaiagents/agent/agent.py[1876-1964]
- src/praisonai-agents/praisonaiagents/config/presets.py[287-296]
- src/praisonai-agents/praisonaiagents/config/param_resolver.py[586-598]
### Suggested fix
Implement one of:
1) Resolve `context` in `__init__` before assigning `self._context_param`:
- `str` -> apply `CONTEXT_PRESETS` and build a `ContextConfig` (or ManagerConfig alias)
- `dict` -> `ContextConfig(**context)` with key validation
2) Alternatively, add handling for `str`/`dict` inside `context_manager` property.
Add tests for `Agent(context="summarize")` and `Agent(context={...})` ensuring `agent.context_manager` is not `None`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| caching: Optional[Union[bool, str, Dict[str, Any], 'CachingConfig']] = None, | ||
| hooks: Optional[Union[List[Any], Dict[str, Any], 'HooksConfig']] = None, | ||
| skills: Optional[Union[List[str], str, Dict[str, Any], 'SkillsConfig']] = None, | ||
| approval: Optional[Union[bool, str, Dict[str, Any], 'ApprovalConfig', 'ApprovalProtocol']] = None, |
There was a problem hiding this comment.
3. Approval dict backend crash 🐞 Bug ≡ Correctness
Agent.__init__ now advertises approval can be a dict, but approval setup stores unknown types directly as _approval_backend, so a dict becomes the backend. Tool execution then calls backend.request_approval(...), which will raise AttributeError on a dict.
Agent Prompt
### Issue description
`Agent.__init__` now type-hints `approval` as accepting a `dict`, but the approval initialization code does not handle dicts and will store them as `_approval_backend`. Later, tool execution calls `backend.request_approval(...)`, which will crash with `AttributeError` for dict backends.
### Issue Context
There is an `ApprovalConfig` dataclass intended for structured configuration, and the runtime expects `_approval_backend` to implement `ApprovalProtocol` (`request_approval`).
### Fix Focus Areas
- src/praisonai-agents/praisonaiagents/agent/agent.py[1619-1658]
- src/praisonai-agents/praisonaiagents/agent/tool_execution.py[426-485]
- src/praisonai-agents/praisonaiagents/approval/protocols.py[55-83]
### Suggested fix
Add an explicit dict branch in Agent approval setup, e.g.:
- `elif isinstance(approval, dict): approval = ApprovalConfig(**approval)` (and optionally validate allowed keys)
Then let the existing `isinstance(approval, ApprovalConfig)` branch configure `_approval_backend`.
Alternatively, remove `Dict[str, Any]` from the type hint if dict configuration is not supported.
Add a unit test that passes `approval={"backend": SomeBackend(), "all_tools": True, "timeout": 10}` and verifies tool execution reaches the backend without crashing.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above first. Review areas:
|
|
@claude You are the FINAL architecture reviewer. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding. Phase 1: Review per AGENTS.md
Phase 2: FIX Valid Issues Phase 3: Final Verdict |
|
Claude finished @MervinPraison's task —— View job Final Architecture Review & Bug Fixes ✅I've completed the final review and implemented all necessary fixes. Phase 1: Architecture Review per AGENTS.md
Phase 2: Fix Valid Issues
Phase 3: Final Verdict
Architecture Compliance Summary✅ AGENTS.md Compliant: This PR properly follows the parameter consolidation pattern (§5.3): ✅ Protocol-Driven: No heavy implementations added to core SDK Bugs FixedAll 4 critical bugs identified by reviewers have been RESOLVED: 1. ✅ Autonomy String Bug (
2. ✅ Context String/Dict Bug (
3. ✅ Approval Dict Bug (
4. ✅ Learn String Bug (
Testing Results✅ All fixes verified working:
Files ModifiedPushed to branch
🎯 Final Verdict: APPROVEDThis PR is READY TO MERGE ✅
The widened type hints now have proper runtime support, delivering the promised flexibility while maintaining backward compatibility. |
- Add string preset handling in _init_autonomy() for autonomy='full_auto' etc.
- Add str/dict support in context_manager property for context='summarize' etc.
- Add dict-to-ApprovalConfig conversion for approval={'backend': ..., 'all_tools': True}
- Add string mode handling in learn parameter for learn='agentic' etc.
- Fix AUTONOMY_PRESETS to use 'level' field (not 'mode') per AutonomyConfig
Resolves type hint/implementation mismatches identified by code reviewers.
All new type hints now have proper runtime support.
Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>
- Narrow context hint: remove str/Dict (init has no handling for those) - Narrow autonomy hint: remove str (no string-level preset handling) - Narrow templates hint: remove str (resolve() returns None with no presets) - Narrow approval hint: remove Dict (init only handles bool/str/ApprovalConfig/Protocol) - Narrow learn hint: remove str; replace silent passthrough with a logged warning - Update docstrings for output/execution/templates/learn to reflect actual supported types Agent-Logs-Url: https://github.com/MervinPraison/PraisonAI/sessions/e371c8e1-a816-4fb2-8eb8-a18242daa2de Co-authored-by: MervinPraison <454862+MervinPraison@users.noreply.github.com>
…e that don't After rebase, commit 72e477f added runtime support for: - context str/dict -> restore to type hint - autonomy str -> restore to type hint - approval dict -> restore to type hint - learn str -> restore to type hint templates str remains removed (resolve() with no presets returns None). Updated all docstrings to document actual supported types including new forms. Agent-Logs-Url: https://github.com/MervinPraison/PraisonAI/sessions/e371c8e1-a816-4fb2-8eb8-a18242daa2de Co-authored-by: MervinPraison <454862+MervinPraison@users.noreply.github.com>
Completed a thorough review and addressed all the reviewer feedback in commit Type hints vs. runtime behavior (addressed in
Bug fix: Replaced the silent Docstrings: Updated Review areas:
|
contexttype hint: restoredstr/Dict— runtime handles presets "sliding_window"/"summarize"/"truncate" and dict→ContextConfigautonomytype hint: restoredstr— runtime handles level presets "suggest"/"auto_edit"/"full_auto"templatestype hint: removedstr(no TEMPLATE_PRESETS defined; resolver returnsNonefor unknown strings)approvaltype hint: restoredDict[str, Any]— runtime converts dict toApprovalConfig(**dict)learntype hint: restoredstr— runtime maps "agentic"/"propose"/"disabled" toLearnConfig(mode=...)learnpassthrough bug: replaced silent_learn_config = learnwith a logged warning for truly unknown typescontext/autonomy/output/execution/templates/learnto reflect all actual supported input types